Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal Template: Horizontal and Vertical ScrollBars visible by deafult in IFrames. #251

Open
soumikgm opened this issue May 26, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@soumikgm
Copy link

soumikgm commented May 26, 2021

There exists horizontal and vertical scrollbars on iframes by default. This sometimes leads to double scrollbars when a microservice uses its own scroll. The expected behavior is no scrollbars by default.
image

@soumikgm soumikgm added the bug Something isn't working label May 26, 2021
@einari
Copy link
Contributor

einari commented May 30, 2021

Thanks. We should fix the templates so that they are correct.
The styling of the iframe is not managed by Vanir. When creating a new Vanir application and adding a Portal to it, the template adds SCSS files that could be used to style this and make it look correct (https://github.com/dolittle/vanir/blob/main/Source/typescript/create-dolittle-microservice/templates/portal/Source/%7B%7B%20pascalCase%20name%20%7D%7D/Web/index.scss).

So for your project, which has probably been bootstrapped with this template you can go and edit the index.scss file within the Portal/Web project.

I will update the title of this to reflect that this would be to fix the template.

@einari einari changed the title Frontend - Horizontal and Vertical ScrollBars visible by deafult in IFrames. Portal Template: Horizontal and Vertical ScrollBars visible by deafult in IFrames. May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants