Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format changes empty NamedTuple to empty Tuple #343

Closed
ericphanson opened this issue Dec 8, 2020 · 5 comments
Closed

format changes empty NamedTuple to empty Tuple #343

ericphanson opened this issue Dec 8, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@ericphanson
Copy link

with JuliaFormatter v0.11,

julia> format_text("(;)")
"()"

As of JuliaLang/julia#30115 (i.e. Julia 1.5) this is valid syntax for a NamedTuple.
@ericphanson ericphanson mentioned this issue Dec 8, 2020
Merged
@domluna domluna added the bug Something isn't working label Dec 8, 2020
@domluna
Copy link
Owner

domluna commented Dec 8, 2020

have to double check if CSTParser supports this atm

@domluna
Copy link
Owner

domluna commented Dec 9, 2020 •
edited
Loading

CSTParser doesn't parse the semicolon so I'll have to look for that similar to the way it's done for parameters or matrices until it's changed

@domluna
Copy link
Owner

domluna commented Dec 9, 2020

ref julia-vscode/CSTParser.jl#207

@nickrobinson251
Copy link
Contributor

#285

@ericphanson
Copy link
Author

Oops, missed that one— closing as duplicate

@nickrobinson251 nickrobinson251 mentioned this issue Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domluna @ericphanson @nickrobinson251