Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce scopes when creating/updating applications #1009

Closed
talklittle opened this issue Jan 3, 2018 · 0 comments
Closed

Enforce scopes when creating/updating applications #1009

talklittle opened this issue Jan 3, 2018 · 0 comments

Comments

@talklittle
Copy link
Contributor

Followup to #896

Doorkeeper should enforce the scopes when creating/editing registered applications via /oauth/applications/new and /oauth/applications/123/edit.

Currently it is possible to enter nonexistent scopes (like "blahblah") when creating/editing an application, and those scopes will be used in the authorization step. When authorizing to the application, the /oauth/authorize page shows the untranslated scope names, and authorization succeeds. No error messages are displayed, other than the tooltip saying the scope is not translated.

In other words, there is not much purpose to the optional_scopes configuration, since those can be easily ignored/overridden when registering a new application. It seems to me that the default behavior should be to enforce each application's scopes are in either default_scopes or optional_scopes, during the application's create/update step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant