Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dora service is not started. An error is reported execute dora list #250

Closed
meua opened this issue Apr 14, 2023 · 5 comments · Fixed by #254
Closed

The dora service is not started. An error is reported execute dora list #250

meua opened this issue Apr 14, 2023 · 5 comments · Fixed by #254

Comments

@meua
Copy link
Contributor

meua commented Apr 14, 2023

Describe the bug
The dora service is not started. An error is reported execute dora list

To Reproduce
Steps to reproduce the behavior:

  1. dora list

Screenshots or Video
QQ20230414-201905

Environments (please complete the following information):

  • System info: Linux jia 5.15.0-69-generic #76~20.04.1-Ubuntu SMP Mon Mar 20 15:54:19 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
  • Dora version : 0.2.2
@phil-opp
Copy link
Collaborator

Could you clarify what behavior you are expecting? Do you think that the coordinator and daemon should be started automatically on dora list? Or do mean that we should improve the error message to e.g. "no dora coordinator is running" instead of "Connection refused"?

@meua
Copy link
Contributor Author

meua commented Apr 18, 2023

Could you clarify what behavior you are expecting? Do you think that the coordinator and daemon should be started automatically on dora list? Or do mean that we should improve the error message to e.g. "no dora coordinator is running" instead of "Connection refused"?

No, I think that when dora is not started, execute the dora list command, it should not report an error, it should remind the prompt that dora is not started

@phil-opp
Copy link
Collaborator

Thanks for clarifying! I opened #254 to fix this.

@haixuanTao
Copy link
Collaborator

I may be wrong, but is this issue more geared toward the way the error is reported rather than the actual content of the error @meua ?

@meua
Copy link
Contributor Author

meua commented Apr 19, 2023

I may be wrong, but is this issue more geared toward the way the error is reported rather than the actual content of the error @meua ?

The dora return should clearly explain the cause of the problem, and should not directly throw an exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants