Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix declarationKind=class syntax errors #3183

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Fix declarationKind=class syntax errors #3183

merged 1 commit into from
Dec 31, 2019

Conversation

dotansimha
Copy link
Owner

related: #3102

@dotansimha dotansimha merged commit 5f3a7c2 into master Dec 31, 2019
@dotansimha dotansimha deleted the fix-declaration-kind-class branch December 31, 2019 12:49
@dotansimha dotansimha mentioned this pull request Dec 31, 2019
Closed
@738
Copy link
Contributor

738 commented Feb 11, 2020

@dotansimha As well as class, i think interface, type, abstract class should be changed into semicolon, not comma. (except enum)

can I contribute?

@dotansimha
Copy link
Owner Author

@738 this could really help :) PRs are always welcome!

738 added a commit to 738/graphql-code-generator that referenced this pull request Feb 14, 2020
@738
fix that if declarationKind is class, interface, type in typesc…
a8c18e7 
…ript, and `class`, `interface` in flow, the punctuation should be semicolon, not comma. (dotansimha#3102, dotansimha#3183)
@738 738 mentioned this pull request Feb 14, 2020
Merged
dotansimha pushed a commit that referenced this pull request Feb 16, 2020
@738
Fix declarationKind=interface, type syntax errors (#3505)
fe5fbff 
* fix typo in typescript.spec.ts

* fix typo in react-apollo.spec.ts (somehting -> something)

* fix tests that if declarationKind is `class`, `interface`, `type` in typescript, and `class`, `interface` in flow, the punctuation should be semicolon, not comma.

* fix that if declarationKind is `class`, `interface`, `type` in typescript, and `class`, `interface` in flow, the punctuation should be semicolon, not comma. (#3102, #3183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotansimha @738