throw from resolver should not be logged

[marktani]

@steida commented on Mon Feb 26 2018

Maybe I am wrong, but

const throwError = (error /*: ServerError */) => {
  throw new Error(JSON.stringify(error));
};

const throwNotAuthorizedError = () => throwError({ type: 'notAuthorized' });

Seems to be a recommended way how to stop resolver, but then probably this should not be logged.

[schickling]

Thanks a lot for bringing this up @steida. If I'm not mistaken then it's actually not graphql-yoga which implements the error logging but one of the underlying GraphQL libraries (I guess apollo-server-express). We should dig a bit deeper into this and see where the logging originates.

Do you want a setting to disable error logging or rather an easy way to catch all of these errors and implement your own handling?

[steida]

@schickling Own handling, definitely. Do you have any idea how?

[schickling]

@timsuchanek @divyenduz can you describe a couple of approaches here?

[danutzcodrescu]

@steida you can install apollo-errors package and then implement your own errors. You can implement your custom errors like it is presented in Apollo documentation

[steida]

Actually, I moved all errors to the schema where it belongs. And https://github.com/maticzav/graphql-shield soon allow controlling logging I guess.

[steida]

@schickling Feel free to close it. Thank you.

[johannpinson]

Hello @danutzcodrescu

After seen your comment, I also looked about this one #167

After make some test by adding apollo-errors (unofficial) to my project, I didn't get more information inside the error object in the response .
Actually, it seems we need to use directly apollo-server-errors (official) and extend ApolloError class.

[rvlewerissa]

@johannpinson Hi, how do you manage to make the error response log disappears?

I tried the following:

import {ApolloError} from 'apollo-server-errors';

// and in resolver
throw new ApolloError('Not Authorized!');

doesn't work..

[johannpinson]

hey @rvlewerissa

Actually I reviewed my workflow and I use Apollo Server v2 directly, so I didn't have even more this problem 😉

[rvlewerissa]

@johannpinson Ah I see.. Thanks

[samuela]

I'd like to vote against this actually, or at least for a modified version. This has the very unfortunate side effect of hiding "legitimate" errors, without any record of them. That makes things extremely hard to reproduce and debug when fit hits the shan. It seems to me that the ideal way to cover this would be to skip logging on certain classes of Errors (NotAuthorizedError and so on), but maintain logs for all others. I really want to know why things aren't working when my database fails to connect, my resolver logic is flawed, or a third-party package misbehaves.

[MohamedElmdary]

@marktani if you still facing this problem you need to add debug: false in start options

const options = {
  port: 8080,
  endpoint: "/graphql",
  subscriptions: "/subscriptions",
  playground: "/playground",
  formatError(err: any): any {
    return err.message;
  },
  debug: false // this would prevent logs
};

server.start(options, () => {
  console.log("server started!");
});

[rista404]

@samuela I had the some problem, and the following did the job for me:

import {
	isInstance as isApolloErrorInstance,
	formatError as formatApolloError,
} from 'apollo-errors'

export default function formatError(error) {
	const { originalError } = error

	// Skip logging Apollo controlled errors
	if (isApolloErrorInstance(originalError)) {

		// Maybe do stuff with apollo error

		return formatApolloError(error)
	}

	// Finally, log uncontrolled errors
	console.error(error)

	return error
}

I assume all apollo errors (from apollo-errors package) are controlled, and skip logging them.

[stale]

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

[samuela]

bump to unstale?

[stale]

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

[samuela]

bump

[ken-nah]

@marktani if you still facing this problem you need to add debug: false in start options

const options = {
  port: 8080,
  endpoint: "/graphql",
  subscriptions: "/subscriptions",
  playground: "/playground",
  formatError(err: any): any {
    return err.message;
  },
  debug: false // this would prevent logs
};

server.start(options, () => {
  console.log("server started!");
});

This worked for me.

[ardatan]

I think plugins from Envelop's ecosystem with error masking can be used to solve this issue;
See https://www.graphql-yoga.com/docs/features/error-masking

[factoidforrest]

I don't see how I can call a custom handler with that. I can turn off masking, but how about doing something critically important, like logging the error? Where is the formatError function?

[ardatan]

You can manage error handling as described in here;
https://www.the-guild.dev/graphql/yoga-server/docs/features/error-masking