Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous types in the package. #585

Closed
akash-rajput opened this issue Jul 23, 2019 · 4 comments
Closed

Erroneous types in the package. #585

akash-rajput opened this issue Jul 23, 2019 · 4 comments

Comments

@akash-rajput
Copy link

akash-rajput commented Jul 23, 2019

The types declared for options & others as well allow string | false where it should actually be string | boolean. Please correct me if this is intentional. Thanks.

Screenshot 2019-07-23 at 1 21 13 PM

This gives type errors while passing config options
Screenshot 2019-07-23 at 1 24 43 PM

@colelawrence
Copy link

Would you share more of this file @akash-rajput ? The displayed error messages make this look like something else in this file is actually causing this type error.

@colin-lear-at-austal
Copy link

Seeing errors like:

Type 'string | boolean' is not assignable to type 'string | false | undefined'

@abhischekt
Copy link

I'm seeing the same error:
image

@saihaj saihaj mentioned this issue Dec 5, 2021
32 tasks
@saihaj
Copy link
Collaborator

saihaj commented Feb 19, 2022

Hey @akash-rajput @abhischekt @colelawrence @colin-lear-at-austal we @the-guild-org are the new maintainers of this project. We are actively working on v2. We wrote the ground up using Typescript and added many new features. So this should be addressed now. Would love to get your feedback on beta release. You can checkout our new docs https://www.graphql-yoga.com (still wip)

@saihaj saihaj closed this as completed Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants