Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update express to 4.17 to set sameSite: 'none' cookie #623

Closed
adithya321 opened this issue Feb 19, 2020 · 7 comments
Closed

Update express to 4.17 to set sameSite: 'none' cookie #623

adithya321 opened this issue Feb 19, 2020 · 7 comments

Comments

@adithya321
Copy link

expressjs/express#3958

@baileymckay
Copy link

This is really important. I have a production application breaking now when clients update their Chrome to a version that rejects any cookies without this set. It should be an easy fix, no? Express has already been updated to support this.

@lejager
Copy link

lejager commented Mar 28, 2020

Any progress? I also have a production app that users are no longer able to log in to.

@gregegan
Copy link

Bump. Having the same issue. Can we please support sameSite: 'none'?

@greggall
Copy link

Yes, need this supported please!

@Asjas
Copy link

Asjas commented Oct 12, 2020

You should be able to get it working by resolving Express to a newer version such as 4.17.0. You can add this to your package.json file as an extra field.

"resolutions": {
  "express": "4.17.0"
}

If you are using yarn then support for this functionality is included out of the box, if you are using npm then you need to use a package such as npm-force-resolutions. This should allow you to then set the sameSite property. 🙂

https://github.com/rogeriochaves/npm-force-resolutions#how-to-use

@Asjas
Copy link

Asjas commented Mar 17, 2021

As an update to this issue, you can fix it by deleting your package-lock.json or yarn.lock file and then reinstalling the npm packages. When you install the npm packages it should then resolve to a newer version of Express that supports the sameSite option and you will get a updated package-lock.json 🙂

@saihaj
Copy link
Collaborator

saihaj commented Feb 19, 2022

Hey @adithya321 @baileymckay @Asjas @gregegan @greggall @lejager we @the-guild-org are the new maintainers for this project. We are actively developing v2. The new yoga server is framework agnostic, so you can bring framework of your choice! Checkout our express server integration https://www.graphql-yoga.com/docs/integrations/integration-with-express would love to get your feedback on this!

@saihaj saihaj closed this as completed Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants