Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: Remove .laminas-ci/pre-run.sh #332

Open
alexmerlin opened this issue Feb 7, 2025 · 1 comment
Open

[RFC]: Remove .laminas-ci/pre-run.sh #332

alexmerlin opened this issue Feb 7, 2025 · 1 comment

Comments

@alexmerlin
Copy link
Member

Based on this PR, before runtime, Laminas' CI action should now be able to correctly determine and install the required PHP extensions (assuming they are present in composer.json). For this, we probably need to add ext-sqlite under require-dev.

With this, we should remove .laminas-ci/pre-run.sh from our projects and the CI actions should still be able to run successfully.

@MarioRadu Thoughts?
@MarioRadu
Copy link
Member

We can try to remove it and if it's correctly installing the dependencies we can remove .laminas-ci/pre-run.sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexmerlin @MarioRadu