Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock service injection for integration tests topic #7511

Merged
merged 3 commits into from
Aug 1, 2018

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Jul 7, 2018

Fixes #7153

Internal Review Topic

  • Adds content to the topic to cover injection of mock services with ConfigureTestServices.
  • Adds an example of injecting a simple mocked service into the sample app.

cc/ @lambdakris You won't be able to see the internally-built doc; but if you flip over to the diff, you'll see the enhancement. I think this would have been enough to show you the way to go, but let me know if not.

@guardrex guardrex requested review from javiercn, scottaddie and Rick-Anderson and removed request for scottaddie July 7, 2018 18:30
@scottaddie
Copy link
Member

@guardrex The snippet displays correctly in the preview page. Try upgrading to the latest version of DocFX, if you haven't already.

@guardrex
Copy link
Collaborator Author

guardrex commented Jul 9, 2018

I did. No 🎲🎲.

@Rick-Anderson
Copy link
Contributor

@javiercn please review

@guardrex guardrex mentioned this pull request Jul 28, 2018
32 tasks
@guardrex
Copy link
Collaborator Author

guardrex commented Aug 1, 2018

@Rick-Anderson I updated the versions. I reviewed the text updates ... look'in good 👍, and I checked the sample again ...

Total tests: 14. Passed: 14. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 8.7050 Seconds

Shall we go ahead and merge?

@Rick-Anderson Rick-Anderson merged commit 1c9c2bc into master Aug 1, 2018
@guardrex guardrex deleted the guardrex/int-testing-update branch August 1, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants