RP conventions topic+sample updates #8523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guardrex
force-pushed
the
guardrex/rp-conventions2
branch
from
22ba661 to
60109ec
Compare
Updates Updates
guardrex
force-pushed
the
guardrex/rp-conventions2
branch
from
9430fd6 to
d23e1ed
Compare
guardrex
changed the title
rynowak
reviewed
Sep 17, 2018
| * When routes have the same `Order`, the most specific route is matched first followed by less specific routes. | ||
| * When routes with the same `Order` and the same number of parameters match a request URL, routes are processed in the order that they're added to the <xref:Microsoft.AspNetCore.Mvc.ApplicationModels.PageConventionCollection>. | ||
|
|
||
| If possible, avoid depending on an established route processing order. Generally, routing selects the correct route with URL matching. If you must set route `Order` properties to route requests correctly, the app's routing scheme is probably confusing to clients and fragile to maintain. Seek to simplify the app's routing scheme. The sample app requires an explicit route processing order to demonstrate several routing scenarios using a single app. However, you should attempt to avoid the practice of setting route `Order` in production apps. |
There was a problem hiding this comment.
This section all seems pretty good. If there's details about this in the regular routing section it might be helpful to link it. This is a shared implementation with regular routing.
There was a problem hiding this comment.
Yes, there's one spot in routing where this is discussed, and there is some duplication. Of course, PageCollectionConvention isn't discussed over there. I'll take another look at this in a few minutes and see about cross-linking both ways (just in case someone looking for RP content lands over there).
rynowak
approved these changes
Sep 17, 2018
scottaddie
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6173
Internal Review Topic
@rynowak This follows our discussion on aspnet/Mvc#8385.
Thanks again to @user135711 for surfacing the issues.