Add a package abstraction for System.IO.Packaging

[twsouthwick]

The Package and PackagePart types from System.IO.Packaging are not built in a way to make composition easy; they do not expose public overridable methods. These abstractions will help with smoothing over some issues found in those types that are difficult to manage.

[lindexi]

Awesome, thank you

[mikeebowen]

Looks good, just a small question about String.Concat() vs +

[mikeebowen]

Would it be better to use String.Concat() here instead?

[mikeebowen]

Would it be better to use String.Concat() here instead?

[twsouthwick]

Probably - there are many issues with the FlatOpc implementations regarding performance... this PR was focused on replacing things with the ipackage rather than fixing anything else.

[lindexi]

Looks good, thank you

[michaelcsikos]

How do I do this now that Package is Obsolete?

var newId = (uint)(spreadsheetDocument.Package.GetRelationships().Count() + 1);
var rId   = "relId" + newId;

...

spreadsheetDocument.Package.CreateRelationship(uri,
                                               TargetMode.Internal,
                                               "http://schemas.openxmlformats.org/officeDocument/2006/relationships/worksheet",
                                               rId);

It would be nice if the Obsolete message pointed us in the right direction. I'm rolling back to 2.19.0 for now.

[eSPiYa]

So, how to get parts of the packages now?
Our code is like this:

using(var doc = WordprocessingDocument.Open(filepath, true)){
var fontTable = doc.MainDocumentPart.OpenXmlPackage.Package.GetPart(new Uri(@"/word/fontTable.xml", UriKind.Relative));

// some operations here

doc.Close();
}

[XavierNV]

Same as @eSPiYa ... I used to get a packagepart for a image (mediaUrl) in a presentation with this code
Dim ioPackage As IO.Packaging.Package = presDocument.Package
Dim pckPart = ioPackage.GetPart(mediaUri)
how can i get it now ?

[twsouthwick]

The obsolete has been obsoleted :) I heard enough feedback of people using this that I've reverted that. However, in v3.0, it's a new type with similar shape that should be a drop in replacement (the System.IO.Packaging types are just not as composable as needed)

[twsouthwick]

For now, we're not planning on releasing a v2.20.1 - this is mostly because we had to move to GH actions during this timeframe and we haven't back ported those changes to that branch. If having a v2.20.1 with the obsolete removed would be helpful for migrating to v3.0, please thumbs up this and we can prioritize it.

[XavierNV]

Thanks a lot for your feedback. We'll wait for v3.0 final version...