Enable package initialization that doesn't get copied #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeebowen
previously approved these changes
Nov 19, 2024
With the pipelining added in 3.0.1 used internally for creating packages, it caused any initializing of the package (i.e. from FlatOpc) to be repeated on clones which we don't want. This fixes it for the near term to unblock users, but will be followed with a consolidation of the uses of IPackageInitialzier.
twsouthwick
force-pushed
the
fix-flatopc-and-cloning
branch
from
0f4cf0c
to
2984934
Compare
AlfredHellstern
approved these changes
Nov 19, 2024
|
@mikeebowen looks like it rejected your approval after I pushed some updates |
mikeebowen
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the pipelining added in 3.0.1 used internally for creating packages, it caused any initializing of the package (i.e. from FlatOpc) to be repeated on clones which we don't want. This fixes the templates (both FlatOpc and document templates) from not being captures in the package creation but kept separate for an initialization step.
Fixes #1814