Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NetStandard from AddOns scripts #2977

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Nov 5, 2024

The scripts are trying to build configurations there were removed in #2386 , looks like these instances were missed

@ErikEJ
Copy link
Contributor

ErikEJ commented Nov 5, 2024

LGTM (I guess is missed this)

@benrr101
Copy link
Contributor

benrr101 commented Nov 5, 2024

@mdaigle Can you take a look at this one? It looks good to me as long as it builds. But you've been waist-deep in build pipelines so I'll trust your judgement more.

@benrr101
Copy link
Contributor

benrr101 commented Nov 5, 2024

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@benrr101 benrr101 added the Area\Engineering Issues that are targeted for changes in the 'eng' folder or build systems. label Nov 5, 2024
@cheenamalhotra cheenamalhotra merged commit 58c1347 into dotnet:main Nov 6, 2024
7 checks passed
@mdaigle mdaigle added this to the 6.0-preview3 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Engineering Issues that are targeted for changes in the 'eng' folder or build systems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants