Safely handle DirectoryNotFound #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially the same thing as our `FileNotFoundException` handling, however here we also have to fabricate the directory tree. Fixes https://github.com/dotnet/aspnetcore/issues/22795
TanayParikh
requested review from
ajaybhargavb,
noahbkim,
NTaylorMullen and
ryanbrandenburg
as code owners
NTaylorMullen
requested changes
Jun 10, 2020
...Razor/src/Microsoft.AspNetCore.Razor.LanguageServer.Common/DefaultRemoteTextLoaderFactory.cs
Outdated
Show resolved
Hide resolved
NTaylorMullen
approved these changes
Jun 11, 2020
ajaybhargavb
approved these changes
Jun 11, 2020
noahbkim
pushed a commit
that referenced
this pull request
Jul 6, 2020
* Safely handle DirectoryNotFound Fixes https://github.com/dotnet/aspnetcore/issues/22795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially the same thing as our
FileNotFoundExceptionhandling, however here we also have to fabricate the directory tree.Fixes https://github.com/dotnet/aspnetcore/issues/22795