Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On text document change, update HTML in VS LSP client #17836

Closed
NTaylorMullen opened this issue Dec 12, 2019 · 1 comment · Fixed by dotnet/razor#1659
Closed

On text document change, update HTML in VS LSP client #17836

NTaylorMullen opened this issue Dec 12, 2019 · 1 comment · Fixed by dotnet/razor#1659
Assignees
@ajaybhargavb
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Milestone
Razor LSP Preview 3

Comments

@NTaylorMullen
Copy link
Contributor

The Razor language server will already have the smarts to push down HTML updates to the client when the primary document is changed. This item encompasses listening for those push events and updating all the client side state properly.
@NTaylorMullen NTaylorMullen added enhancement This issue represents an ask for new feature or an enhancement to an existing one cost: S area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Dec 12, 2019
@NTaylorMullen NTaylorMullen added this to the Razor.Tooling milestone Dec 12, 2019
@NTaylorMullen NTaylorMullen added the blocked The work on this issue is blocked due to some dependency label Feb 28, 2020
@NTaylorMullen
Copy link
Contributor Author

@ajaybhargavb assigning to you to handle updating the HTML buffer in the VS client. It'll be a good warm-up to the VS tech and the C# buffer update PR can be used as reference

@ajaybhargavb ajaybhargavb mentioned this issue Mar 6, 2020
Merged
@ajaybhargavb ajaybhargavb removed the blocked The work on this issue is blocked due to some dependency label Mar 7, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Apr 6, 2020
@NTaylorMullen NTaylorMullen added the Done This issue has been fixed label Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Milestone
Razor LSP Preview 3
Development

Successfully merging a pull request may close this issue.

Wire up updating the LSP background html document dotnet/razor
2 participants
@ajaybhargavb @NTaylorMullen