Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest O# LangaugeServer Extension #5550

Closed
22 of 23 tasks
NTaylorMullen opened this issue Mar 30, 2020 · 7 comments · Fixed by #2439
Closed
22 of 23 tasks

Upgrade to latest O# LangaugeServer Extension #5550

NTaylorMullen opened this issue Mar 30, 2020 · 7 comments · Fixed by #2439
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Contributor

https://www.nuget.org/packages/OmniSharp.Extensions.LanguageServer/

  • Will be able to remove our AutoFlushingStream impl

  • Make sure that hovers/completions/whatnot work on HTMLY files.

  • Try removing AutoFlushingStream

Needs Verification in VS:

  • SemanticTokens (Ryan)
  • Completions
  • Completion resolve
  • signatureHelp
  • documentHighlight
  • codeAction
  • codeLens
  • formatting
  • onTYpeFormatting
  • rename

Needs Verification in VSCode:

  • SemanticTokens (Ryan)
  • Hover
  • Completions
  • Completion resolve
  • signatureHelp
  • documentHighlight
  • codeAction
  • codeLens
  • formatting
  • onTYpeFormatting
  • rename
@NTaylorMullen NTaylorMullen changed the title Upgrade to O# LangaugeServer Extension 16.0 Upgrade to latest O# LangaugeServer Extension Mar 30, 2020
@ryanbrandenburg ryanbrandenburg self-assigned this Apr 2, 2020
@TanayParikh
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg self-assigned this Aug 6, 2020
@NTaylorMullen
Copy link
Contributor Author

@NTaylorMullen
Copy link
Contributor Author

NTaylorMullen commented Aug 18, 2020

@NTaylorMullen
Copy link
Contributor Author

I believe this will also resolve: https://github.com/dotnet/aspnetcore/issues/25116

@ryanbrandenburg
Copy link
Contributor

ryanbrandenburg commented Aug 26, 2020

Post-upgrade problems:

  • No codelens in vscode or VS
  • No completions in VS
  • No signatureHelp in VSCode
  • Lightbulb on unknown taghelper hangs in VS
  • Rename doesn't work in VS
  • OnTypeFormatting doesn't work in VS
  • AutoCompletion doesn't work in VS
  • VSCode gives errors about Synchronization failed: Token cancellation requested: undefined

@TanayParikh
Copy link
Contributor

TanayParikh commented Aug 26, 2020

Lightbulb on unknown taghelper hangs in VS

So something like:
<NonExistantComponent> -> invoke lightbulb -> VS hangs?

Or unknown as in missing a using / fully qualified namespace?

@ryanbrandenburg
Copy link
Contributor

Like your example, except instead of "invoke lightbulb" it's just "click on the lightbulb (assumedly just to get a list of available actions)"

@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2020
@ghost ghost unlocked this conversation Oct 9, 2021
@allisonchou allisonchou transferred this issue from dotnet/aspnetcore Oct 9, 2021
@allisonchou allisonchou added this to the 16.8-Preview3 milestone Oct 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants