CompletionOptions from Multiple Language Servers Aren't Respected

[TanayParikh]

If I add:

AllCommitCharacters = new[] { ":", ">" },

to the Razor.LanguageServer CompletionOptions here these characters aren't accepted to commit completions proposed by this language server.

I have to add the commit char (:) to the LanguageServerClient CompletionOptions here.

Now even though the Razor.LanguageServer proposes the completion, and doesn't have any commit characters specified in the CompletionOptions, :, which was specified in the LanguageServerClient successfully commits the completion.

This poses as issue in cases like this where we want : to commit the @onkeypress razor directive attribute but not the onkeypress html attribute.

[TanayParikh]

Once this issue is resolved, https://github.com/dotnet/aspnetcore-tooling/pull/1825/files#diff-dddd024b99ebbf567eea61e984e7a9f6R21 needs to be updated to remove the : commit char.

AllCommitCharacters = new[] { ":", ">", " ", "=" },

also needs to be added to the Razor.LanguageServer CompletionOptions here to allow for commits of Razor directive attributes and <text> tags.

[NTaylorMullen]

Should file a vsts issue to track this as well and make sure the LSP platform team knows about it

[TanayParikh]

#1825 has been merged in.

Created a VSTS issue and reached out to the appropriate team to see if we can get this resolved to support CompletionOptions.AllCommitCharacters from multiple language servers. Marking as blocked as it has an external dependency.

[TanayParikh]

The fix for this was merged in and inserted. Will verify once the new build propagates.

[TanayParikh]

Tried out the latest insertion, however the issue seems to persist.

Investigated into the VS LSP codebase, and identified a potential issue. Following up with them on the existing VSTS issue.

[TanayParikh]

New VSTS Issue.

[TanayParikh]

Still blocked externally by LSP Platform, backlog'ing for now. Followed up with LSP Platform and will update accordingly.

[TanayParikh]

This should be unblocked soon (LSP Platform just inserted this in).