Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contextually Provide Attribute Commit Characters #5505

Closed
TanayParikh opened this issue May 5, 2020 · 1 comment · Fixed by #1825
Closed

Contextually Provide Attribute Commit Characters #5505

TanayParikh opened this issue May 5, 2020 · 1 comment · Fixed by #1825
Assignees
Milestone

Comments

@TanayParikh
Copy link
Contributor

We should understand the attribute type for both directive attributes and taghelper attributes, and provide the appropriate commit characters ( , :, =, etc.).

@TanayParikh TanayParikh self-assigned this May 5, 2020
@TanayParikh
Copy link
Contributor Author

TanayParikh commented May 5, 2020

After investigation (Thanks @ajaybhargavb for helping clarify different cases / requirements):
Two separate cases:

  1. Directive Attributes.
    • No commit characters for indexer attributes. (ends with ... ex. bind-...)
    • Otherwise always provide =
    • Provide if bool property
    • Provide : if parameters present
  2. TagHelper Attributes
    • No commit characters for indexer attributes.
    • Otherwise always provide =
    • Provide if bool property

@ghost ghost locked as resolved and limited conversation to collaborators Jun 21, 2020
@ghost ghost unlocked this conversation Oct 9, 2021
@allisonchou allisonchou transferred this issue from dotnet/aspnetcore Oct 9, 2021
@allisonchou allisonchou added this to the 16.7-Preview2 milestone Oct 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants