Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Implement Interface/Abstract Class C# Code Action #5155

Closed
TanayParikh opened this issue Sep 15, 2020 · 2 comments · Fixed by #2551
Closed

Support Implement Interface/Abstract Class C# Code Action #5155

TanayParikh opened this issue Sep 15, 2020 · 2 comments · Fixed by #2551
Assignees
@TanayParikh
Milestone
16.9-Preview1

Comments

@TanayParikh
Copy link
Contributor

  • Implement Interface
  • Implement Abstract Class
class SomethingDisposable : IDisposable
{

}
  • Involves implementing new TSLanguageServer/HTMLCSharpLanguageServer razor/codeActionResolve endpoint which resolves code actions with Roslyn.
  • Will likely require omnisharp-vscode changes to fully support.
@TanayParikh TanayParikh self-assigned this Sep 15, 2020
TanayParikh referenced this issue Sep 16, 2020
@TanayParikh
Support CSharp Light Bulbs (FQN, Add Using) (#2501)
66dbb85 
### Summary of the changes

- Support for Fully Qualified Namespace C# Light Bulb
![FullyQualifiedCodeAction](https://user-images.githubusercontent.com/14852843/93262976-f1da7f80-f759-11ea-9877-05e9df2ed88b.gif)

- Support for Add Using C# Light bulb
![AddUsingCodeAction](https://user-images.githubusercontent.com/14852843/93263130-2d754980-f75a-11ea-890d-bfb07516a354.gif)

- Abstraction Layer / Refactoring to create shared light bulb infrastructure between TSLanguageServer + HTMLCSharpLanguageServer.
- This implementation doesn't have support for code actions which require resolving with Roslyn (ex. via `textDocument/codeActionResolve`). Working on an appropriate expansion for this, and will likely require changes in `omnisharp-vscode`.
    - Tracked here: https://github.com/dotnet/aspnetcore/issues/25918
- Some general perf optimizations are possible, but wanted to avoid potential pre-optimizations. Will re-visit if we see issues.
- Testing: TODO assuming no issues with the design.

Fixes: https://github.com/dotnet/aspnetcore/issues/24779
Fixes: https://github.com/dotnet/aspnetcore/issues/18173
Fixes: https://github.com/dotnet/aspnetcore/issues/24778
Fixes: https://github.com/dotnet/aspnetcore/issues/25144
@NTaylorMullen
Copy link
Contributor

@TanayParikh should this move to 16.9-Preview1?

@TanayParikh
Copy link
Contributor Author

@TanayParikh should this move to 16.9-Preview1?

Yep. Have it mostly working but I don't think it's quite yet ready for primetime.

@ghost ghost closed this as completed in #2551 Oct 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2020
@ghost ghost unlocked this conversation Oct 9, 2021
@allisonchou allisonchou transferred this issue from dotnet/aspnetcore Oct 9, 2021
@allisonchou allisonchou added this to the 16.9-Preview1 milestone Oct 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TanayParikh TanayParikh

Labels
None yet
Projects
None yet
Milestone
16.9-Preview1
Development

Successfully merging a pull request may close this issue.

Resolve Based Code Actions dotnet/razor
3 participants
@NTaylorMullen @TanayParikh @allisonchou