Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpSys tests failing in Helix on Windows #50916

Open
wtgodbe opened this issue Sep 25, 2023 · 6 comments
Open

HttpSys tests failing in Helix on Windows #50916

wtgodbe opened this issue Sep 25, 2023 · 6 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-httpsys test-failure
Milestone
Test failures

Comments

@wtgodbe
Copy link
Member

wtgodbe commented Sep 25, 2023 •
edited by BrennanConroy
Loading

Tests are failing on Windows.Amd64.VS2022.Pre

Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.Http2Tests.AppException_AfterHeaders_PriorOSVersions_ResetCancel
Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.Http2Tests.Reset_PriorOSVersions_NotSupported

System.Net.Http.HttpRequestException : Response status code does not indicate success: 500 (Internal Server Error).

at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
at System.Net.Http.HttpClient.GetStringAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
at Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.Http2Tests.Reset_PriorOSVersions_NotSupported() in /_/src/Servers/HttpSys/test/FunctionalTests/Http2Tests.cs:line 646
--- End of stack trace from previous location ---

Windows Version:

Major Minor Build Revision
10 0 17763 4720

Logs:

[0.001s] [TestLifetime] [Information] Starting test Reset_PriorOSVersions_NotSupported at 2023-09-22T22:12:35
[0.002s] [Microsoft.AspNetCore.Server.HttpSys.HttpSysListener] [Debug] Listening on prefix: https://localhost:44323/
[0.025s] [Microsoft.AspNetCore.Server.HttpSys.HttpSysListener] [Debug] CreateDisconnectToken; Registering connection for disconnect for connection ID: 18086456113720459443
[0.028s] [Microsoft.AspNetCore.Server.HttpSys.HttpSysListener] [Error] ProcessRequestAsync
Xunit.Sdk.NullException: Assert.Null() Failure
Expected: (null)
Actual:   RequestContext`1 { CanDelegate = True, DisconnectToken = System.Threading.CancellationToken, IsUpgradableRequest = False, Request = Request { Body = NullStream { ... }, CanDelegate = True, CipherAlgorithm = Aes256, CipherStrength = 256, ClientCertificate = null, ... }, RequestInfo = [[2] = System.ReadOnlyMemory<Byte>[28]], ... }
   at Xunit.Assert.Null(Object object) in /_/src/xunit.assert/Asserts/NullAsserts.cs:line 44
   at Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.Http2Tests.<>c.<Reset_PriorOSVersions_NotSupported>b__15_0(HttpContext httpContext) in /_/src/Servers/HttpSys/test/FunctionalTests/Http2Tests.cs:line 638
   at Microsoft.AspNetCore.Server.HttpSys.DummyApplication.ProcessRequestAsync(HttpContext httpContext) in /_/src/Servers/HttpSys/test/FunctionalTests/DummyApplication.cs:line 35
   at Microsoft.AspNetCore.Server.HttpSys.RequestContext`1.ExecuteAsync() in /_/src/Servers/HttpSys/src/RequestProcessing/RequestContextOfT.cs:line 47
   at Microsoft.AspNetCore.Server.HttpSys.RequestContext`1.ExecuteAsync() in /_/src/Servers/HttpSys/src/RequestProcessing/RequestContextOfT.cs:line 52
[0.032s] [Microsoft.AspNetCore.Server.HttpSys.HttpSysListener] [Debug] CreateDisconnectToken; http.sys disconnect callback fired for connection ID: 18086456113720459443
[0.035s] [Microsoft.AspNetCore.Server.HttpSys.HttpSysListener] [Information] Stop listening on prefix: https://localhost:44323/
[0.036s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.036s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.036s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.036s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.037s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.037s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.037s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.037s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.037s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.037s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.037s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.037s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.038s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.038s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.038s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.038s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.038s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.038s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.038s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.039s] [Microsoft.AspNetCore.Server.HttpSys.MessagePump] [Debug] Failed to accept a request, the server is stopping.
Microsoft.AspNetCore.Server.HttpSys.HttpSysException (995): The I/O operation has been aborted because of either a thread exit or an application request.
   at Microsoft.AspNetCore.Server.HttpSys.AsyncAcceptContext.GetResult(Int16 token) in /_/src/Servers/HttpSys/src/AsyncAcceptContext.cs:line 204
   at Microsoft.AspNetCore.Server.HttpSys.MessagePump.AcceptLoop.ExecuteAsync() in /_/src/Servers/HttpSys/src/MessagePump.cs:line 256
[0.041s] [Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.Http2Tests] [Error] Test threw an exception.
System.Net.Http.HttpRequestException: Response status code does not indicate success: 500 (Internal Server Error).
   at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
   at System.Net.Http.HttpClient.GetStringAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.Http2Tests.Reset_PriorOSVersions_NotSupported() in /_/src/Servers/HttpSys/test/FunctionalTests/Http2Tests.cs:line 646
   at Xunit.Sdk.TestInvoker`1.<>c__DisplayClass48_0.<<InvokeTestMethodAsync>b__1>d.MoveNext() in /_/src/xunit.execution/Sdk/Frameworks/Runners/TestInvoker.cs:line 264
--- End of stack trace from previous location ---
   at Xunit.Sdk.ExecutionTimer.AggregateAsync(Func`1 asyncAction) in /_/src/xunit.execution/Sdk/Frameworks/ExecutionTimer.cs:line 48
   at Xunit.Sdk.ExceptionAggregator.RunAsync(Func`1 code) in /_/src/xunit.core/Sdk/ExceptionAggregator.cs:line 90
[0.041s] [TestLifetime] [Information] Finished test Reset_PriorOSVersions_NotSupported in 0.0401549s

Build https://dev.azure.com/dnceng/internal/_build/results?buildId=2274452&view=ms.vss-test-web.build-test-results-tab&runId=52149483&resultId=122541&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Sep 25, 2023
@BrennanConroy BrennanConroy mentioned this issue Sep 25, 2023
Merged
@Tratcher
Copy link
Member

Where are the logs?
Link to a build?

@Tratcher
Copy link
Member

The reset feature got backported to RS5/WS2019. The product code seems to have correctly detected the new functionality, we just have to adjust the test's expected OS versions.

@wtgodbe
Copy link
Member Author

wtgodbe commented Oct 2, 2023 •
edited
Loading

Do you know the Windows versions to update the tests to (the build numbers, etc)?

@Tratcher
Copy link
Member

Tratcher commented Oct 2, 2023

Only that it's working now on the version given above.

@amcasey
Copy link
Member

amcasey commented Nov 21, 2023

So the work here is to find an older windows build number that doesn't have the fix these tests verify isn't present?

@amcasey amcasey added this to the Test failures milestone Nov 21, 2023
@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 29, 2023

I belive so

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-httpsys test-failure
Projects
None yet
Milestone
Test failures
Development

No branches or pull requests
3 participants
@Tratcher @amcasey @wtgodbe