Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugging: Update dictionary debuggers in aspnetcore to follow the new standard #51827

Closed
17 tasks done
JamesNK opened this issue Nov 2, 2023 · 5 comments · Fixed by #52867
Closed
17 tasks done

Debugging: Update dictionary debuggers in aspnetcore to follow the new standard #51827

JamesNK opened this issue Nov 2, 2023 · 5 comments · Fixed by #52867
Assignees
@JamesNK
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions good first issue Good for newcomers. help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team

Comments

@JamesNK
Copy link
Member

JamesNK commented Nov 2, 2023 •
edited
Loading

dotnet/runtime#92534 updates dictionaries to display the key in the name instead of an index.

We should update name/value collections in ASP.NET Core to follow the same pattern.

There are a lot of custom dictionaries to update:
@JamesNK JamesNK added the help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team label Nov 2, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Nov 2, 2023
@danmoseley danmoseley added the good first issue Good for newcomers. label Nov 2, 2023
@danmoseley
Copy link
Member

danmoseley commented Nov 2, 2023 •
edited
Loading

Cc @arturek

@shiladitya-mukerji-22
Copy link
Contributor

Hey @JamesNK, I would like to work on this update. Can you assign the issue to me.

@JamesNK
Copy link
Member Author

JamesNK commented Nov 10, 2023

@shiladitya-mukerji-22 I suggest you start with one or two collections, establish a pattern that can be reused, and then create a PR.

A small PR lets us review it and suggest changes. Once it is good, you or something else can apply the changes to all of the collections.

@JamesNK
Copy link
Member Author

JamesNK commented Dec 9, 2023

@shiladitya-mukerji-22 Do you still plan to look at this? If not, I wouldn't mind making these changes.

@JamesNK
Copy link
Member Author

JamesNK commented Dec 17, 2023

I'm going to look at this next week.

@JamesNK JamesNK mentioned this issue Dec 18, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JamesNK JamesNK

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions good first issue Good for newcomers. help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve debug views of dictionaries dotnet/aspnetcore
3 participants
@JamesNK @danmoseley @shiladitya-mukerji-22