-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messaging for 404s #5350
Comments
Also if the server has a bug and doesn't expose the hub properly, you get an "Error negotiating: error" which makes you think its actually communicated with the server when in fact it hasn't. I'd think messing up the hub definition on the server is quite common for newbies. Cheers, |
Can you elaborate on what you mean by "doesn't expose the hub properly"? |
I think @ptallett means when you incorrectly configure map hub and the client try to a wrong hub url. |
There's nothing we can do about that. If you point your client at www.google.com, we don't get a chance to handle it properly. Maybe we could log the mapped hubs at startup and the URL they are bound to. I'm not sure what we could do on the client side besides improve the error message to say we didn't find the negotiate response? |
I think the ask here is to have an error that actually says we got a 404. At the moment I believe we have a very obscure error. That seems entirely legitimate. |
I see. This is across all the clients right? |
The JavaScript client is the one with the worst error messages :). The others are pretty good already. |
The easiest fix here is to detect the kind of 404 we get. Once a 404 is received:
|
We should do this in all the clients. The JS client is the worst because it has no 404 error (it just says "Error"), but the Java and .NET clients could use the detection logic in 1 above. |
Clarifying further. The work we're doing here is to change all three clients to explicitly detect a |
The work for this repo:
The work for docs (engineering team to do this) (cc @scottaddie):
|
This is cut for 3.0. This can probably meet the bar for 3.1 though. |
You receive a 404 when your JWT-Token you send in the query param is to large: Error during WebSocket handshake: Unexpected response code: 404 |
Usually a 404 occurs because sticky sessions are not enabled. We should provide a better error message here.
The text was updated successfully, but these errors were encountered: