Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query param to check if Blazor WASM app is under debug #24972

Merged
1 commit merged into from
Aug 18, 2020

Conversation

captainsafia
Copy link
Member

Uses a _blazor_debug query param flag to check if the application is currently under debug. For backwards-compat, this value defaults to true. For scenarios where it needs to be disabled, users will need to navigate to https://localhost:5001?_blazor_debug=false when they first visit the page.

We can update the blazorwasm VS Code debug experience to set this value correctly if start without debugging is set. We'll need to do the same in VS. I've pinged the VS debugging team about this.

Addresses #24623

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Aug 17, 2020
@captainsafia captainsafia added the feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly label Aug 17, 2020
@captainsafia
Copy link
Member Author

@guardrex Heads up that this change will require documentation page updates.

@captainsafia captainsafia changed the base branch from master to release/5.0 August 17, 2020 21:39
@captainsafia captainsafia reopened this Aug 17, 2020
@captainsafia captainsafia removed the request for review from dougbu August 18, 2020 16:09
@ghost
Copy link

ghost commented Aug 18, 2020

Hello @captainsafia!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 5297d5f into release/5.0 Aug 18, 2020
@ghost ghost deleted the safia/dbg-check branch August 18, 2020 18:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants