This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Don't use GCC libstdc++ wrappers for stdlib.h #5304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents #undef of min/max macros. Refs #5006.
|
Thanks for the patch! @janvorli can you take a look? |
|
LGTM, thank you very much for investigating and fixing the issue! |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This prevents #undef of min/max macros. Refs dotnet/coreclr#5006. Commit migrated from dotnet/coreclr@41912e3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent GCC-Versions (>= 6) added C++-conforming wrappers for stdlib.h and math.h, which broke the build of pal:
mbstring.cpp:182:20: error: use of undeclared identifier 'min'[Detailed description of root cause](https://github.com/dotnet/coreclr/issues/5006#issuecomment-
222191925)
The definition of
_GLIBCXX_INCLUDE_NEXT_C_HEADERSprevents the use of the new wrappers.