GitHub webhook causing incorrect linking/issue state changes in Azure DevOps issues

[missymessa]

A webhook in GitHub is causing incorrect linking of issues or state change of issues in Azure DevOps.

For example, this comment was left on an issue in Azure DevOps: https://dnceng.visualstudio.com/internal/_workitems/edit/5102/#7296315

issue that commented was related to: dotnet/vscode-csharp#5102

commit: Resolve issue #5102: Support input variables for envFile (#5189) · dotnet/vscode-csharp@7b1f541 (github.com)

dnceng mirror commit: Commit 7b1f541a: Resolve issue #5102: Support input variables for envFile (#5189)... - Repos (visualstudio.com)

Additionally, some brief investigation with @dibarbet showed that about 125 issues in Azure DevOps have been affected indirectly by him via this bug. I would assume that more than that have been affected through others' activities.

Release Note Category

• Feature changes/additions
• Bug fixes
• Internal Infrastructure Improvements

Release Note Description

[AlitzelMendez]

@premun gave some updates on this that confirmed what I saw during my investigation.

This is a summary of what he says

This only happens when some GH repo gets within a range of IDs that are currently in AzDO so it happens only sometimes which makes it even harder to notice.

https://learn.microsoft.com/en-us/azure/devops/repos/git/resolution-mentions?view=azure-devops

Close work items using commit messages - Azure Repos

How to close work items using commit messages

looks like we can remove this feature

We can take this route, we just need to send an email to inform them about this change and confirm no one is using the feature.

[premun]

We should only do that for mirrored repositories but I would go as far and say that this will be turned off.

We should also update instructions for new repo creation.

[AlitzelMendez]

This has been done and I created this pr to update the documentation: https://dev.azure.com/dnceng/internal/_git/dotnet-eng-wiki/pullrequest/32216