-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing with UWP and Visual Studio 2019 (16.*) #5011
Comments
I have the same issue with: Building metadata for a netstandard2.0 class library.
docfx.json {
"metadata": [
{
"src": [
{
"src": "../src",
"exclude": [ "**/bin/**", "**/obj/**" ],
"files": [
"**/*.csproj"
]
}
],
"dest": "api",
"disableGitFeatures": false,
"disableDefaultFilter": false,
"properties": {
"TargetFramework": "netstandard2.0"
}
}
]
} |
What can I do or how can I help to get this issue resolved? |
Hi @phraemer , I tried building the project and got the warning below:
From error message, I find msbuild was trying to locate Then I modified the project like https://github.com/phraemer/TestDocfx/pull/1 and docfx can generate document successfully. Note that you should use docfx >= 2.47 to avoid hitting #4782. |
Hi @superyyrrzz , thanks for looking into this. It looks like the error is different now since I last tried but your changes get us one step further. Does this mean we need to inform the MSBuild team or the Visual Studio team to fix that? Note that this is a clean project generated by Visual Studio. After I merged your changes docfx does build a site but does not find anything to document in the project.
|
I created an issue to Visual Studio for this: https://developercommunity.visualstudio.com/content/problem/862455/wrong-import-path-for-microsoftwindowsuixamlcsharp.html I do not meet your new warnings. What version of Visual Studio are you using? |
Hi sorry for the delay replying due to the holidays. I just tried the repo I provided again with VS 16.4.2 and DocFX 2.48.1.0 The site does build and serve but again no docs produces for the comments and there are warnings:
The line...
made me suspect it needs building first. So I built the solution in VS with Debug/x64 and ran
Is it a requirement for docfx that the solution or project is built first with VS or msbuild? I would have thought it builds whatever it needs itself. Did I miss something in the documentation? I would expect to see the summary of the class As always any help greatly appreciated and just ask if I can do anything to help. |
Docfx runs msbuild internally. Normally you need not build it beforehand. However, I remembered in some case it need, e.g. when there is some unresotred nuget packages.
I have not idea about this. You can create another issue for this with more details. I am closing this issue as UWP projects can build now. |
Thanks for the fix! |
Operation System: Windows
DocFX Version Used: 2.44.0.0
Template used:
default
Steps to Reproduce:
I made a clean UWP project with Visual Studio and beside it did
docfx init -q
and made the few changes I believed necessary to point it at the project.I have a repo of the entire thing here:
https://github.com/phraemer/TestDocfx
Not sure if the
TargetFramework
should benet46
but previously it has worked with VS 2017 projects and older docfx versions like 2.40 or so.Expected Behavior:
Generates the site.
Actual Behavior:
Errors out with:
The text was updated successfully, but these errors were encountered: