Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Update docfx choco package #8856

Closed
jamaa opened this issue Jun 10, 2023 · 5 comments
Closed

[Feature Request] Update docfx choco package #8856

jamaa opened this issue Jun 10, 2023 · 5 comments
Labels
fundamental Engineering system and core components

Comments

@jamaa
Copy link

jamaa commented Jun 10, 2023

Is your feature request related to a problem? Please describe.
I use docfx in github actions, where docfx is installed using chocolatey. However, the latest available choco package of docfx is 2.59.4. I would like to be able to use a more recent version.

Describe the solution you'd like
Update the choco package of docfx to a more recent release.

Describe alternatives you've considered

Additional context

@yufeih yufeih added the fundamental Engineering system and core components label Jun 12, 2023
@yufeih
Copy link
Contributor

yufeih commented Jun 13, 2023

Is it possible to change the installation script to use dotnet tool install -g docfx?

@jamaa
Copy link
Author

jamaa commented Jun 13, 2023

Thanks, yes, that actually works. But I am now facing a different problem which I think is due to the latest docfx always using the latest available .NET SDK to build the project (in GitHub actions this is currently .NET Core SDK 7.0.302). The project in question still uses .NET Framework 4.8 and cannot be built using the newer SDKs (I think the underlying issue is dotnet restore not properly restoring the NuGet dependencies). (See details here).

Using the old docfx 2.59.4, the build works. It doesn't say so explicitly in the log, but I believe it is using .NET Core 3.1 for the build.

Is there any way to tell docfx which .NET SDK to use within a GitHub action?

@colewerner
Copy link

Similar to this it would be nice if the docfx.console nuget package were updated to the latest as new versions are released. We currently leverage the nuget package from a cake/ps build script system to build docfx sites. It looks like it hasn't been updated in 9 months or so.

@colewerner
Copy link

colewerner commented Jun 16, 2023

It looks like the publishing of the docfx.console nuget package and the choco package were both deprecated as part of the PR:
#8280

It was also in a discussion here:
#8415

It seems the approach at this point is to install the dotnet tool via dotnet tool install -g docfx

@jamaa
Copy link
Author

jamaa commented Jun 17, 2023

ok thanks. Maybe it's possible to mark the choco project as deprecated or to at least add some relevant info to the description there to avoid people asking the same questions as me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fundamental Engineering system and core components
Projects
None yet
Development

No branches or pull requests

3 participants