Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should expand the existing documentation to include the new publish msbuild properties and their options #13980

Closed
jeffschwMSFT opened this issue Aug 21, 2019 — with docs.microsoft.com · 3 comments · Fixed by #17787
Closed

We should expand the existing documentation to include the new publish msbuild properties and their options #13980

jeffschwMSFT opened this issue Aug 21, 2019 — with docs.microsoft.com · 3 comments · Fixed by #17787
Assignees
@tdykstra
Labels
cli/subsvc doc-enhancement Improve the current content [org][type][category]
Milestone
Backlog

Comments

@jeffschwMSFT docs.microsoft.com
Copy link
Member

We should add details about the three new publishing options:
<PropertyGroup>
<PublishTrimmed>true</PublishTrimmed>
<PublishReadyToRun>true</PublishReadyToRun>
<PublishSingleFile>true</PublishSingleFile>
</PropertyGroup>

In addition we should include all the optional configuration settings as well.
https://github.com/dotnet/designs/blob/master/accepted/single-file/design.md#build-system-interface
https://aka.ms/dotnet-illink

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@swaroop-sridhar
Copy link
Contributor

swaroop-sridhar commented Aug 21, 2019 •
edited
Loading

Overlaps with #13149

@mairaw
Copy link
Contributor

mairaw commented Aug 21, 2019

It's fine @swaroop-sridhar. I'll review this article next as I update the CLI reference docs and then we can check what's left on the original issue.

@mairaw mairaw self-assigned this Aug 21, 2019
@mairaw mairaw added this to the Backlog milestone Aug 21, 2019
@mairaw mairaw added the P1 label Aug 21, 2019
@nxtn
Copy link
Contributor

nxtn commented Sep 15, 2019

What about the "old" property PublishDir? dotnet/cli#8405

@tdykstra tdykstra added the doc-enhancement Improve the current content [org][type][category] label Dec 12, 2019
@dagood dagood mentioned this issue Jan 6, 2020
Closed
@mairaw mairaw removed their assignment Feb 15, 2020
@tdykstra tdykstra self-assigned this Mar 9, 2020
This was referenced Apr 10, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdykstra tdykstra

Labels
cli/subsvc doc-enhancement Improve the current content [org][type][category]
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

dotnet publish CLI ref updates tdykstra/dotnet-docs
7 participants
@BillWagner @tdykstra @swaroop-sridhar @dotnet-bot @jeffschwMSFT @mairaw @nxtn