Expose a schema transformer on AIJsonSchemaCreateOptions. #5677
+215
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriktsarpalis
commented
Nov 20, 2024
src/Libraries/Microsoft.Extensions.AI.Abstractions/Utilities/AIJsonUtilities.Schema.cs
Show resolved
Hide resolved
stephentoub
reviewed
Nov 20, 2024
src/Libraries/Microsoft.Extensions.AI.Abstractions/Utilities/AIJsonSchemaCreateOptions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Nov 20, 2024
src/Libraries/Microsoft.Extensions.AI.Abstractions/Utilities/AIJsonSchemaCreateContext.cs
Show resolved
Hide resolved
stephentoub
reviewed
Nov 20, 2024
src/Libraries/Microsoft.Extensions.AI.Abstractions/Utilities/AIJsonUtilities.Schema.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Nov 20, 2024
eiriktsarpalis
commented
Nov 20, 2024
src/Libraries/Microsoft.Extensions.AI.Abstractions/Utilities/AIJsonUtilities.Schema.cs
Outdated
Show resolved
Hide resolved
stephentoub
pushed a commit
to stephentoub/extensions
that referenced
this pull request
Nov 20, 2024
* Expose a schema transformer on AIJsonSchemaCreateOptions. * Address feedback * Disable caching if a transformer is specified. * Remove `FilterDisallowedKeywords`. * Document caching. * Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With https://github.com/eiriktsarpalis/stj-schema-mapper being migrated to M.E.AI and archived,
AIJsonUtilitieshas become the de facto standard API for exporting JSON schemas that's available in both .NET 8 and .NET 9. Partner teams that have been relying onstj-schema-mappersource copies will soon need to start usingAIJsonUtilitiesinstead.In order to make this functionality more useful from a customizability perspective, this PR exposes the schema transformer functionality on
AIJsonSchemaCreateOptions.Microsoft Reviewers: Open in CodeFlow