Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnAppearing not called if returning from a modal page to a modal page #11498

Closed
AndreasReitberger opened this issue Nov 19, 2022 · 3 comments · Fixed by #13177
Closed

OnAppearing not called if returning from a modal page to a modal page #11498

AndreasReitberger opened this issue Nov 19, 2022 · 3 comments · Fixed by #13177
Labels
area-controls-modal area-core-lifecycle XPlat and Native UIApplicationDelegate/Activity/Window lifecycle events fixed-in-7.0.81 Look for this fix in 7.0.81! fixed-in-7.0.92 Look for this fix in 7.0.92! fixed-in-7.0.100 fixed-in-7.0.101 fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! platform/iOS 🍎 s/duplicate 2️⃣ This issue or pull request already exists t/bug Something isn't working

Comments

@AndreasReitberger
Copy link

AndreasReitberger commented Nov 19, 2022

Description

I'm not sure if this is by design, so if not, please let me know. Please see the attached repro.

protected override async void OnAppearing()
    {
       // Set breakpoint here for both modals
        base.OnAppearing(); 
        try
        {
            await ((WatchlistDetailsModalPageViewModel)BindingContext).OnAppearing();
        }
        catch (Exception) { }
    }

Steps to Reproduce

  1. Create a new maui app and add two modals pages to it
  2. Override the OnAppearing and set a break point
  3. Use Shell to navigate to the first modal and see, that the breakpoint is hit.
  4. Navigate to the next modal page, also this breakpoint is hit
  5. Navigate back using Shell, and see that the breakpoint of modal number 1 is not hit on appearing

Link to public reproduction project repository

https://github.com/AndreasReitberger/ReproScrollingIssueModal

Version with bug

7.0 (current)

Last version that worked well

Unknown/Other

Affected platforms

iOS, I was not able test on other platforms

Affected platform versions

iOS 16.1, but also could be not relevant to version

Did you find any workaround?

No response

Relevant log output

No response

@AndreasReitberger AndreasReitberger added the t/bug Something isn't working label Nov 19, 2022
@marcmognol
Copy link
Contributor

Hi,
Duplicate of #8513?

Marc

@jsuarezruiz jsuarezruiz added area-controls-modal area-core-lifecycle XPlat and Native UIApplicationDelegate/Activity/Window lifecycle events s/duplicate 2️⃣ This issue or pull request already exists labels Nov 21, 2022
@jsuarezruiz jsuarezruiz added this to the Backlog milestone Nov 21, 2022
@ghost
Copy link

ghost commented Nov 21, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@SailDev
Copy link

SailDev commented Feb 4, 2023

Cross reference, to draw more attention to the problem:
Link

@samhouts samhouts added the fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! label Feb 22, 2023
@samhouts samhouts modified the milestones: Backlog, 8.0-preview1 Feb 22, 2023
@samhouts samhouts added the fixed-in-7.0.81 Look for this fix in 7.0.81! label Apr 12, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
@samhouts samhouts added the fixed-in-7.0.92 Look for this fix in 7.0.92! label Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-modal area-core-lifecycle XPlat and Native UIApplicationDelegate/Activity/Window lifecycle events fixed-in-7.0.81 Look for this fix in 7.0.81! fixed-in-7.0.92 Look for this fix in 7.0.92! fixed-in-7.0.100 fixed-in-7.0.101 fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! platform/iOS 🍎 s/duplicate 2️⃣ This issue or pull request already exists t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants