Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Write device test to validate CharacterSpacing changes #13361

Closed
rmarinho opened this issue Feb 15, 2023 · 1 comment · Fixed by #16603
Closed

[iOS] Write device test to validate CharacterSpacing changes #13361

rmarinho opened this issue Feb 15, 2023 · 1 comment · Fixed by #16603
Assignees
Labels
area-testing Unit tests, device tests fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 platform/iOS 🍎 Task neither bug nor feature but something that needs to be done in support of either

Comments

@rmarinho
Copy link
Member

Description

When fixing #10293 I wanted to add a device test to see if the Button size changes after CharacterSpacing changing, but I wasn't able to getting it working.

Creating this issue to track and look at adding the test again when I have more time, or someone else as a good idea how to do it.

what I was trying :

[Yesterday 17:07] Rui Marinho
await InvokeOnMainThreadAsync(async () =>
{
        var handler = CreateHandler(button);
         await handler.PlatformView.AttachAndRun(async () =>
         {
                    var initialFrame = handler.PlatformView.Bounds;
                    button.CharacterSpacing = xplatCharacterSpacing;                             
                    await Task.Delay(1000);
                    var afterFrame = handler.PlatformView.Bounds;
                    Assert.True(afterFrame.Width > initialFrame.Width);
          });
});

Steps to Reproduce

Try add test above

Link to public reproduction project repository

none

Version with bug

7.0 (current)

Last version that worked well

Unknown/Other

Affected platforms

iOS

Affected platform versions

all

Did you find any workaround?

No response

Relevant log output

No response

@rmarinho rmarinho added platform/iOS 🍎 area-testing Unit tests, device tests labels Feb 15, 2023
@rmarinho rmarinho added this to the Backlog milestone Feb 15, 2023
@ghost
Copy link

ghost commented Feb 15, 2023

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@samhouts samhouts added the Task neither bug nor feature but something that needs to be done in support of either label Jul 31, 2023
@jsuarezruiz jsuarezruiz self-assigned this Aug 8, 2023
@jsuarezruiz jsuarezruiz moved this from Todo to In Progress in MAUI SDK Ongoing Aug 8, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in MAUI SDK Ongoing Aug 9, 2023
@samhouts samhouts modified the milestones: Backlog, .NET 8 Aug 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 platform/iOS 🍎 Task neither bug nor feature but something that needs to be done in support of either
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants