Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAUI] The list does not show newly added recipes #22417

Closed
kevinxufei opened this issue May 15, 2024 · 3 comments
Closed

[MAUI] The list does not show newly added recipes #22417

kevinxufei opened this issue May 15, 2024 · 3 comments
Assignees
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView csi-new i/regression This issue described a confirmed regression on a currently supported version p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint platform/windows 🪟 s/triaged Issue has been reviewed t/bug Something isn't working
Milestone

Comments

@kevinxufei
Copy link

kevinxufei commented May 15, 2024

Description

The list does not show newly added recipes

Note: The issue only repro on windows platform

Steps to Reproduce

  1. Clone https://github.com/rachelkang/recipeSearch and deploy it to windows platform
  2. Navigate to My Recipes-> 'New', and add new recipe.
  3. The list does not show newly added recipes

Expected: The list should show newly added recipes

Actual: The list does not show newly added recipes
maui4

Link to public reproduction project repository

https://github.com/rachelkang/recipeSearch.git

Version with bug

Microsoft.Maui.Controls 8.0.60-ci.net8.10665+azdo.9579251

Is this a regression from previous behavior?

This bug is a regression, it can be reproduced in 8.0.40, but can not be reproduced in 8.0.3, and it works fine on Microsoft.Maui.Controls 8.0.40-nightly.10612+sha.752eed7129-azdo.9538080.

Affected platforms

Windows

@kevinxufei kevinxufei added t/bug Something isn't working platform/windows 🪟 s/triaged Issue has been reviewed i/regression This issue described a confirmed regression on a currently supported version csi-new labels May 15, 2024
Copy link
Contributor

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@PureWeen PureWeen modified the milestones: .NET 8 SR5, .NET 8 SR6 May 15, 2024
@jsuarezruiz jsuarezruiz self-assigned this May 16, 2024
@jsuarezruiz jsuarezruiz moved this from Todo to In Progress in MAUI SDK Ongoing May 29, 2024
@jsuarezruiz
Copy link
Contributor

I have been reviewing it:

  • We recently applied changes to the CarouselViewHandler [Windows] Avoid Carousel changes the current position when window is resized #22222 We updated the ItemsSource under different conditions: changes in the size of the control or window, etc.
  • When adding items, we no longer set the ItemsSource again and the UI does not refresh although internally everything is done correctly.
    Using a CollectionViewSource with the ListViewBase of the CarouselView on Windows, everything works correctly although this would break the Loop property. Using LoopableCollectionView, the UI is not updated. Therefore, the focus is currently on reviewing this implementation. We could override and reset ItemsSource but it is a non-optimal solution.

@PureWeen PureWeen assigned Foda and unassigned jsuarezruiz May 31, 2024
@PureWeen PureWeen added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label May 31, 2024
@PureWeen PureWeen modified the milestones: .NET 8 SR6, .NET 8 SR7 Jun 7, 2024
@PureWeen PureWeen modified the milestones: .NET 8 SR7, .NET 8 SR8, .NET 8 SR9 Jul 2, 2024
@samhouts samhouts removed the s/triaged Issue has been reviewed label Jul 3, 2024
@samhouts samhouts added the s/triaged Issue has been reviewed label Jul 10, 2024
@PureWeen PureWeen added the p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint label Aug 2, 2024
@RoiChen001
Copy link

Update:
This issue no longer occurs in 8.0.80.

@github-project-automation github-project-automation bot moved this from In Progress to Done in MAUI SDK Ongoing Aug 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView csi-new i/regression This issue described a confirmed regression on a currently supported version p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint platform/windows 🪟 s/triaged Issue has been reviewed t/bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

6 participants