Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in GoToAsync behavior on Windows in 9.0.12 #26466

Closed
jeremy-visionaid opened this issue Dec 8, 2024 · 13 comments · Fixed by #26521
Closed

Regression in GoToAsync behavior on Windows in 9.0.12 #26466

jeremy-visionaid opened this issue Dec 8, 2024 · 13 comments · Fixed by #26521
Assignees
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout i/regression This issue described a confirmed regression on a currently supported version p/0 Work that we can't release without platform/windows 🪟 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@jeremy-visionaid
Copy link
Contributor

jeremy-visionaid commented Dec 8, 2024

Description

When using an MMVM RelayCommand to invoke GoToAsync, the button invoking the command becomes disabled on Windows.

The behavior is as expected on iOS and Android, and on MAUI 9.0.10 on Windows.

Steps to Reproduce

Clone the repro repo (gotoasync branch)

  1. Click the "Click me" button
  2. Click the back button

The "Click me" button is now disabled

Link to public reproduction project repository

https://github.com/jeremy-visionaid/MauiTestApp/tree/gotoasync

Version with bug

9.0.12 SR1.2

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

9.0.10 SR1

Affected platforms

Windows

Affected platform versions

No response

Did you find any workaround?

Revert back to 9.0.10

Relevant log output

@jeremy-visionaid
Copy link
Contributor Author

Oh, the button can actually still be clicked! It's just the style that is off... i.e. it just looks disabled

@PureWeen
Copy link
Member

PureWeen commented Dec 9, 2024

@jeremy-visionaid I tested your sample on 9.0.0, 9.0.10 and 9.0.12

I'm seeing the same behavior on both versions where the button visually disables

@PureWeen PureWeen added potential-regression This issue described a possible regression on a currently supported version., verification pending platform/windows 🪟 labels Dec 9, 2024
@jeremy-visionaid
Copy link
Contributor Author

After clicking the "Click me" button... then "Back"

9.0.10:
Image

9.0.12:
Image

🤷

@jeremy-visionaid
Copy link
Contributor Author

@PureWeen Did you do a clean/rebuild? I don't think it shows up on an incremental build just changing the version number (which is another problem...).

@PureWeen
Copy link
Member

PureWeen commented Dec 9, 2024

@PureWeen Did you do a clean/rebuild? I don't think it shows up on an incremental build just changing the version number (which is another problem...).

yea, I deleted the bin/obj each time

@PureWeen
Copy link
Member

PureWeen commented Dec 9, 2024

Image

@PureWeen
Copy link
Member

PureWeen commented Dec 9, 2024

What version of windows are you on?

@jeremy-visionaid
Copy link
Contributor Author

24H2: Version 10.0.26100 Build 26100

I'll see if I can repro on a different machine...

@PureWeen
Copy link
Member

PureWeen commented Dec 9, 2024

24H2: Version 10.0.26100 Build 26100

I'll see if I can repro on a different machine...

Same

@jeremy-visionaid
Copy link
Contributor Author

jeremy-visionaid commented Dec 9, 2024

@PureWeen I can repro on both my desktop (Ryzen + NVidia) and my laptop (Intel GPU/GPU), both 24H2.

I assume you can also click the button even though it appears disabled? What happens on Android/iOS for you? For me the button appears enabled on every combination except 9.0.12 on Windows.

Looks like reverting #26108 restores the behaviour in 9.0.10, but I'll just double check...

@PureWeen
Copy link
Member

PureWeen commented Dec 9, 2024

@PureWeen I can repro on both my desktop (Ryzen + NVidia) and my laptop (Intel GPU/GPU), both 24H2.

I assume you can also click the button even though it appears disabled? What happens on Android/iOS for you? For me the button appears enabled on every combination except 9.0.12 on Windows.

Looks like reverting #26108 restores the behaviour in 9.0.10, but I'll just double check...

yea, the behavior is consistent for me between all net9 versions

click button
goes to next page
click back arrow
button looks disabled
button still works

I pinged some folks to test once they are around in a few hours as well

@Ying-6
Copy link

Ying-6 commented Dec 9, 2024

This issue has been verified using Visual Studio 17.13.0 Preview 2.1 (9.0.12). Can repro this issue on Windows Platform, and "Click Me" button works fine on Android platform. And 9.0.10 works fine.
Image

@Ying-6 Ying-6 added s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage i/regression This issue described a confirmed regression on a currently supported version labels Dec 9, 2024
@jfversluis jfversluis removed the potential-regression This issue described a possible regression on a currently supported version., verification pending label Dec 9, 2024
@jfversluis jfversluis added this to the .NET 9 Servicing milestone Dec 9, 2024
@PureWeen PureWeen modified the milestones: .NET 9 Servicing, .NET 9 SR2 Dec 9, 2024
@PureWeen PureWeen moved this from Todo to In Progress in MAUI SDK Ongoing Dec 9, 2024
@Foda Foda self-assigned this Dec 9, 2024
@jfversluis jfversluis added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Dec 9, 2024
@PureWeen PureWeen removed this from the .NET 9 SR2 milestone Dec 11, 2024
@PureWeen PureWeen added this to the .NET 9 SR3 milestone Dec 11, 2024
@jeremy-visionaid
Copy link
Contributor Author

@PureWeen Just to confirm, this is working again in 9.0.14 after reverting #26108

@PureWeen PureWeen added the p/0 Work that we can't release without label Jan 5, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in MAUI SDK Ongoing Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout i/regression This issue described a confirmed regression on a currently supported version p/0 Work that we can't release without platform/windows 🪟 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants