Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SdkResolution.SdkResolverService should be globalized for netcore evaluation #6060

Closed
arunchndr opened this issue Jan 22, 2021 · 1 comment
Closed

SdkResolution.SdkResolverService should be globalized for netcore evaluation #6060

arunchndr opened this issue Jan 22, 2021 · 1 comment
Labels
performance Performance-Scenario-Solution-Open This issue affects solution open performance. Priority:1 Work that is critical for the release, but we could probably ship without triaged
Milestone
VS 17.0

Comments

@arunchndr
Copy link
Member

Child of #6034.

For 400 projects it takes about 1650ms. Can we make this a global task instead of per project and can it be cached after first evaluation?
@arunchndr arunchndr added performance needs-triage Have yet to determine what bucket this goes in. labels Jan 22, 2021
@arunchndr arunchndr mentioned this issue Jan 22, 2021
Closed
18 tasks
@AR-May AR-May added Performance-Scenario-Solution-Open This issue affects solution open performance. and removed needs-triage Have yet to determine what bucket this goes in. labels Jan 28, 2021
@panopticoncentral panopticoncentral added the Priority:1 Work that is critical for the release, but we could probably ship without label Mar 23, 2021
@arunchndr arunchndr mentioned this issue Mar 24, 2021
Merged
@arunchndr
Copy link
Member Author

I believe this task is complete now because of the CPS side consumption of the shared evaluation context apis that showed ~5% solution load gains. @ladipro fyi. Closing this ask.

@ladipro ladipro added this to the VS 17.0 milestone Dec 9, 2021
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Performance-Scenario-Solution-Open This issue affects solution open performance. Priority:1 Work that is critical for the release, but we could probably ship without triaged
Projects
None yet
Milestone
VS 17.0
Development

No branches or pull requests
4 participants
@panopticoncentral @ladipro @arunchndr @AR-May