Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 13 Regressions on 6/14/2024 3:42:32 AM #36512

Open
performanceautofiler bot opened this issue Jun 18, 2024 · 3 comments
Open

[Perf] Linux/x64: 13 Regressions on 6/14/2024 3:42:32 AM #36512

performanceautofiler bot opened this issue Jun 18, 2024 · 3 comments

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 4f9cd4d96e42ee36794480f026c8cad62b6a2407
Compare d901213ed6076c0989a2de2626b99c9711442543
Diff Diff
Configs AOT:true, CompilationMode:wasm, RunKind:micro

Regressions in System.Buffers.Text.Tests.Base64Tests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
724.18 ns 1.13 μs 1.56 0.01 False
723.69 ns 1.13 μs 1.56 0.01 False
906.01 ns 1.30 μs 1.43 0.01 False

graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Buffers.Text.Tests.Base64Tests*'

System.Buffers.Text.Tests.Base64Tests.Base64Encode(NumberOfBytes: 1000)

ETL Files

Histogram

JIT Disasms

System.Buffers.Text.Tests.Base64Tests.Base64EncodeDestinationTooSmall(NumberOfBytes: 1000)

ETL Files

Histogram

JIT Disasms

System.Buffers.Text.Tests.Base64Tests.ConvertToBase64CharArray(NumberOfBytes: 1000)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository


Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 6927fea7b4bca1dc2cea7a0afba0373c1303cedc
Compare d901213ed6076c0989a2de2626b99c9711442543
Diff Diff
Configs AOT:true, CompilationMode:wasm, RunKind:micro

Regressions in System.Text.Json.Serialization.Tests.WriteJson<BinaryData>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
1.20 μs 1.66 μs 1.38 0.03 False
1.01 μs 1.41 μs 1.39 0.02 False
1.72 μs 2.13 μs 1.24 0.02 False
1.48 μs 1.90 μs 1.28 0.02 False

graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.Json.Serialization.Tests.WriteJson&lt;BinaryData&gt;*'

System.Text.Json.Serialization.Tests.WriteJson<BinaryData>.SerializeToWriter(Mode: Reflection)

ETL Files

Histogram

JIT Disasms

System.Text.Json.Serialization.Tests.WriteJson<BinaryData>.SerializeToWriter(Mode: SourceGen)

ETL Files

Histogram

JIT Disasms

System.Text.Json.Serialization.Tests.WriteJson<BinaryData>.SerializeToUtf8Bytes(Mode: Reflection)

ETL Files

Histogram

JIT Disasms

System.Text.Json.Serialization.Tests.WriteJson<BinaryData>.SerializeToUtf8Bytes(Mode: SourceGen)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository


Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 4f9cd4d96e42ee36794480f026c8cad62b6a2407
Compare d901213ed6076c0989a2de2626b99c9711442543
Diff Diff
Configs AOT:true, CompilationMode:wasm, RunKind:micro

Regressions in System.Perf_Convert

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
920.16 ns 1.34 μs 1.46 0.01 False
1.16 μs 1.61 μs 1.38 0.01 False

graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Perf_Convert*'

System.Perf_Convert.ToBase64CharArray(binaryDataSize: 1024, formattingOptions: None)

ETL Files

Histogram

JIT Disasms

System.Perf_Convert.ToBase64String(formattingOptions: None)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository


Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 6927fea7b4bca1dc2cea7a0afba0373c1303cedc
Compare d901213ed6076c0989a2de2626b99c9711442543
Diff Diff
Configs AOT:true, CompilationMode:wasm, RunKind:micro

Regressions in System.Text.Json.Tests.Perf_Base64

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
916.92 ns 1.34 μs 1.46 0.02 False
244.99 ns 316.77 ns 1.29 0.20 False
924.54 ns 1.34 μs 1.45 0.02 False
253.31 ns 330.51 ns 1.30 0.20 False

graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.Json.Tests.Perf_Base64*'

System.Text.Json.Tests.Perf_Base64.WriteByteArrayAsBase64_HeavyEscaping(NumberOfBytes: 1000)

ETL Files

Histogram

JIT Disasms

System.Text.Json.Tests.Perf_Base64.WriteByteArrayAsBase64_HeavyEscaping(NumberOfBytes: 100)

ETL Files

Histogram

JIT Disasms

System.Text.Json.Tests.Perf_Base64.WriteByteArrayAsBase64_NoEscaping(NumberOfBytes: 1000)

ETL Files

Histogram

JIT Disasms

System.Text.Json.Tests.Perf_Base64.WriteByteArrayAsBase64_NoEscaping(NumberOfBytes: 100)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@lewing
Copy link
Member

lewing commented Jun 19, 2024

Looks like this is from dotnet/runtime#102364 and impacts json perf

@lewing
Copy link
Member

lewing commented Jun 19, 2024

cc @buyaa-n

@buyaa-n
Copy link

buyaa-n commented Jul 10, 2024

Must be same as dotnet/runtime#103653 (comment) probably we will not fix, or could be closes as duplicate of dotnet/runtime#103653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants