Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish updated NuGet packages to NuGet.org #3162

Closed
jp2masa opened this issue Jan 18, 2018 · 18 comments
Closed

Publish updated NuGet packages to NuGet.org #3162

jp2masa opened this issue Jan 18, 2018 · 18 comments
Labels
Area-Infrastructure Relates to build, test & run infrastructure of this repo. good-first-issue [up-for-grabs] Good for learning and for external contributors. Relatively self-contained. Triage-Approved Reviewed and prioritized
Milestone

Comments

@jp2masa
Copy link
Member

jp2masa commented Jan 18, 2018

On NuGet, the latest version of Microsoft.VisualStudio.ProjectSystem.Managed and Microsoft.VisualStudio.ProjectSystem.Managed.VS were published 7 months ago. I couldn't find any myget feed with those packages either. What's the correct way of extending the managed project systems?

@Pilchie
Copy link
Member

Pilchie commented Jan 18, 2018

@lifengl?

@Pilchie Pilchie added the Area-External-CPS Owned by CPS and not this repo. Likely be closed in lieu of issue filed against VS platform. label Jan 18, 2018
@Pilchie
Copy link
Member

Pilchie commented Jan 18, 2018

Oh, wait - those are our packages, not the CPS ones :)

@Pilchie Pilchie removed the Area-External-CPS Owned by CPS and not this repo. Likely be closed in lieu of issue filed against VS platform. label Jan 18, 2018
@Pilchie
Copy link
Member

Pilchie commented Jan 18, 2018

They are published to https://dotnet.myget.org/feed/roslyn/package/nuget/Microsoft.VisualStudio.ProjectSystem.Managed, not sure why we haven't pushed them to NuGet.org, but I'll see.

@Pilchie Pilchie self-assigned this Jan 18, 2018
@Pilchie
Copy link
Member

Pilchie commented Jan 19, 2018

@jmarolf @natidea @genlu Do you know why these haven't been published more recently?

@jmarolf
Copy link
Contributor

jmarolf commented Jan 19, 2018

I believe the problem is we never set up a process to track publishing them regularly after balaji left.

@natidea
Copy link
Contributor

natidea commented Jan 19, 2018

This thread has more information about prerelease dependencies that are preventing us from publishing on nuget.org

@jp2masa
Copy link
Member Author

jp2masa commented Jan 19, 2018

The myget packages have some dependencies that shouldn't be there I think, like RoslynTools.RepoToolset and Microsoft.Net.Compilers, these should have PrivateAssets="All". It would be nice if there were stable packages on NuGet, but I understand that it's not really easy, so I can use the myget packages for now.

@Pilchie Pilchie added this to the 15.7 milestone Feb 8, 2018
@Pilchie Pilchie modified the milestones: 15.7, 15.8 Apr 4, 2018
@davkean davkean modified the milestones: 15.8, Unknown May 23, 2018
@davkean davkean added the Area-Infrastructure Relates to build, test & run infrastructure of this repo. label May 23, 2018
@jjmew jjmew added Triage-Approved Reviewed and prioritized and removed Triage-Approved Reviewed and prioritized labels Jan 14, 2019
@MiYanni MiYanni changed the title Extending the managed project systems Publish updated NuGet packages to NuGet.org Jul 27, 2022
@MiYanni
Copy link
Member

MiYanni commented Jul 27, 2022

This issue will be for discussing/deciding if publishing our packages to NuGet.org on a regular basis actually provides any benefit to anyone. At this point in time, I don't know who would consume those packages from that source. We currently publish to 1 public AzDO feed and 1 internal AzDO feed.

@MiYanni MiYanni removed the Triage-Approved Reviewed and prioritized label Jul 27, 2022
@MiYanni MiYanni removed this from the Backlog milestone Jul 27, 2022
@ocallesp
Copy link
Contributor

Maybe we should publish packages to NuGet.org for this specific versions of VS.

@MiYanni
Copy link
Member

MiYanni commented Aug 22, 2022

@ocallesp I think the issue is determining exactly which commit of ours is in those builds. We're not synched enough on our schedule to have a 'release' build of our 'product' that goes into VS. We just keep putting PRs in until the VS release has been cut; even still adding PRs in M2 mode, for example.

@adamint
Copy link
Member

adamint commented Sep 6, 2022

I would recommend against additionally publishing to nuget. If someone external does want to reference, they can just use the ADO feed.

@drewnoakes
Copy link
Member

Perhaps we should unlist all packages from NuGet.org, and make sure the ADO feed is easily discoverable from our readme, if it isn't already.

@MiYanni
Copy link
Member

MiYanni commented Sep 7, 2022

@drewnoakes Yeah, that's what I was thinking too. The main problem is having very old packages on NuGet that people are still downloading. 20+ downloads a day of those old packages is pretty crazy.

https://www.nuget.org/packages/Microsoft.VisualStudio.ProjectSystem.Managed
image

https://www.nuget.org/packages/Microsoft.VisualStudio.ProjectSystem.Managed.VS
image

@drewnoakes
Copy link
Member

Unlisting them won't break those existing users thankfully.

@tmeschter
Copy link
Contributor

We have these available in a public feed already, so we don't need to have them on NuGet.

  • Update the README.md to specify where these can be found
  • Unlist the old packages on nuget.org

@tmeschter tmeschter added the Triage-Approved Reviewed and prioritized label Sep 22, 2022
@tmeschter tmeschter added this to the 17.5 milestone Sep 22, 2022
@kvenkatrajan kvenkatrajan modified the milestones: 17.5, 17.6 Jan 4, 2023
@kvenkatrajan kvenkatrajan added the good-first-issue [up-for-grabs] Good for learning and for external contributors. Relatively self-contained. label Jan 4, 2023
@MiYanni
Copy link
Member

MiYanni commented Jan 5, 2023

Additionally, changes here may want to respond to the discussion here: #7010

@MagicAndre1981
Copy link

but some people have issues getting the previews from the Azure feed. So the better solution is to release (maybe also preview) versions on nuget which all users get.

@drewnoakes
Copy link
Member

Closing in favour of #7010

@drewnoakes drewnoakes closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Relates to build, test & run infrastructure of this repo. good-first-issue [up-for-grabs] Good for learning and for external contributors. Relatively self-contained. Triage-Approved Reviewed and prioritized
Projects
None yet
Development

No branches or pull requests