Skip to content

Commit

Permalink
Fixing completion commit chars (#10533)
Browse files Browse the repository at this point in the history
We don't need to (and shouldn't) specify AllCommitCharacters in capabilities for our completion endpoint. Doing so causes them to always be added to all completion items.

Since we are using our completion endoint for VSCode now, it was causing undesirable behavior there. VSCode HTML doesn't use ">"  as the commit character, and having it specified in server capabilities was causing us to always use ":", ">", " ", and "=" as the commit characters for all items.

See microsoft/vscode#217772
  • Loading branch information
alexgav authored Jun 25, 2024
1 parent 026ae10 commit 277aae8
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ public void ApplyCapabilities(VSInternalServerCapabilities serverCapabilities, V
{
ResolveProvider = true,
TriggerCharacters = _completionListProvider.AggregateTriggerCharacters.ToArray(),
AllCommitCharacters = new[] { ":", ">", " ", "=" },
};
}

Expand Down

0 comments on commit 277aae8

Please sign in to comment.