Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/release/dev17.11' into merges/…
Browse files Browse the repository at this point in the history
…release/dev17.11-to-release/dev17.12

* upstream/release/dev17.11:
  Upgrade System.Security.Cryptography.Xml to avoid CG alerts.
  Update System.Formats.Asn1 to address CG alert.
  Manually reference Microsoft.IO.Redist 6.0.1 where needed to fix CG alerts.
  Upgrade testing analyzers to address CG alert.
  Update version of system.security.cryptography.xml in use in 17.10 (#10525)
  • Loading branch information
333fred committed Aug 13, 2024
2 parents f9c15e4 + ff768a6 commit 80c19df
Show file tree
Hide file tree
Showing 10 changed files with 27 additions and 1 deletion.
2 changes: 2 additions & 0 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
<PackageVersion Include="Microsoft.Extensions.ObjectPool" Version="$(MicrosoftExtensionsObjectPoolPackageVersion)" />
<PackageVersion Include="Microsoft.Internal.VisualStudio.Shell.Framework" Version="$(_MicrosoftVisualStudioShellPackagesVersion)" />
<PackageVersion Include="Microsoft.Internal.VisualStudio.Interop" Version="$(_MicrosoftVisualStudioShellPackagesVersion)" />
<PackageVersion Include="Microsoft.IO.Redist" Version="6.0.1" />
<PackageVersion Include="Microsoft.NET.Sdk.Razor" Version="$(MicrosoftNETSdkRazorPackageVersion)" />
<PackageVersion Include="Microsoft.VisualStudio.Copilot" Version="0.2.28-beta" />
<PackageVersion Include="Microsoft.VisualStudio.ComponentModelHost" Version="$(_MicrosoftVisualStudioPackagesVersion)" />
Expand Down Expand Up @@ -109,6 +110,7 @@
<PackageVersion Include="NuGet.VisualStudio" Version="17.9.1" />
<PackageVersion Include="Roslyn.Diagnostics.Analyzers" Version="$(_MicrosoftCodeAnalysisAnalyzersPackageVersion)" />
<PackageVersion Include="System.Collections.Immutable" Version="$(SystemCollectionsImmutablePackageVersion)" />
<PackageVersion Include="System.Formats.Asn1" Version="6.0.1" />
<PackageVersion Include="System.Resources.Extensions" Version="6.0.0" />
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" />
<PackageVersion Include="System.Private.Uri" Version="4.3.2" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
<ProjectReference Include="..\..\Microsoft.CodeAnalysis.Razor.Compiler\src\Microsoft.CodeAnalysis.Razor.Compiler.csproj" />
<PackageReference Include="BenchmarkDotNet" />
<PackageReference Include="Newtonsoft.Json" />
<PackageReference Include="System.Security.Cryptography.Xml" />
<PackageReference Include="System.Formats.Asn1" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
<PackageReference Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" />
<PackageReference Include="Microsoft.Build.Locator" />
<PackageReference Include="System.Security.Cryptography.Xml" />
<PackageReference Include="System.Formats.Asn1" />
</ItemGroup>

<!-- Reference the local source generator when building in regular configurations -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
<ItemGroup>
<PackageReference Include="Microsoft.VisualStudio.ComponentModelHost" PrivateAssets="all" />
<PackageReference Include="Microsoft.VisualStudio.Shell.Framework" PrivateAssets="all"/>
<!-- Manually upgrade to address CG alert. When the VS packages
pull in the right version, this can be removed. -->
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" PrivateAssets="all"/>
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
<PackageReference Include="Microsoft.CommonLanguageServerProtocol.Framework" PrivateAssets="all" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" />
<!-- Manually upgrade to address CG alert. When the VS packages
pull in the right version, this can be removed. -->
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" />

<!--
Pinning packages to avoid misaligned reference CI failures.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
<PackageReference Include="Microsoft.VisualStudio.LanguageServer.Protocol.Extensions" />
<PackageReference Include="Microsoft.VisualStudio.LanguageServer.Protocol.Internal" />
<PackageReference Include="Microsoft.VisualStudio.LanguageServer.Client.Implementation" />
<!-- Manually upgrade to address CG alert. When the VS packages
pull in the right version, this can be removed. -->
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@

<PackageReference Include="Microsoft.VisualStudio.LiveShare" />
<PackageReference Include="Microsoft.VisualStudio.Shell.15.0" />
<!-- Manually upgrade to address CG alert. When the VS packages
pull in the right version, this can be removed. -->
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" />

<!--
Pinning packages to avoid misaligned reference CI failures.
Expand Down Expand Up @@ -181,4 +184,4 @@

<Import Project="..\..\..\Shared\Microsoft.AspNetCore.Razor.Serialization.Json\Microsoft.AspNetCore.Razor.Serialization.Json.projitems" Label="Shared" />

</Project>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@
<ItemGroup>
<!-- To include the ProvideCodeBase attribute type. -->
<PackageReference Include="Microsoft.VisualStudio.Shell.15.0" />
<!-- Manually upgrade to address CG alert. When the VS packages
pull in the right version, this can be removed. -->
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" />
</ItemGroup>

<!-- Reference the LSP protocol dlls so that we can include them in the code base and output them with the VSIX. -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,9 @@
<PackageReference Include="Microsoft.NET.Sdk.Razor" IncludeAssets="None" PrivateAssets="All" GeneratePathProperty="true" />
<PackageReference Include="System.Resources.Extensions" />
<PackageReference Include="Microsoft.VisualStudio.Shell.15.0" />
<!-- Manually upgrade to address CG alert. When the VS packages
pull in the right version, this can be removed. -->
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" />

<!--
Pinning packages to avoid misaligned reference CI failures.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@
<PackageReference Include="Microsoft.VisualStudio.Extensibility.Testing.Xunit" />
<PackageReference Include="Microsoft.VisualStudio.Extensibility.Testing.SourceGenerator" />
<PackageReference Include="Microsoft.VisualStudio.Language.Intellisense" />
<!-- Manually upgrade to address CG alert. When the VS packages
pull in the right version, this can be removed. -->
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" />
<PackageReference Include="NuGet.VisualStudio" />
<PackageReference Include="Microsoft.Internal.VisualStudio.Shell.Framework" />
<PackageReference Include="xunit.runner.utility" />
Expand Down

0 comments on commit 80c19df

Please sign in to comment.