-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IntelliSense bug for Razor Components #4511
Comments
@mikadumont would you mind suggesting to this person in their first issue about having too many completion items provided to use the filter? I'd be curious if that would resolve their concerns / be appropriate. |
@ToddGrun / @jimmylewis is there an issue about Angular & friends not having their own item filters? Also, if the app doesn't have angular referenced are we able to just not provide the angular completions? |
@NTaylorMullen the ng- completion comes from our HTML editor, not the Angular tooling. We don't have smarts to determine if you're using Angular in the project, but that's also why we collapse it down to only one completion item (if you choose that, we refresh completion with loads of ng-specific stuff). Our assumptions are that in any generic HTML attribute completion scenario: a) one item in completion is easy enough to ignore, b) if you are using Angular, this is super useful to have. If it were the only extraneous one, I don't think we'd get much complaint (we haven't had any feedback on it to date), but when all of the attribute completions are extraneous, it's a much more severe problem. Can Razor smartly determine when to delegate to HTML in these cases? |
Another thought I had: would it be a better experience to tweak the sort order so that the Blazor completion items are listed first? E.g. taking from the element completion screenshot
|
When we adopt the LSP embedded language re-design I have proposed we'd be able to do it easily; doing anything prior to that would be more or less a hack 😢.
Ya that's definitely a possibility. Hmmm probably a pretty good idea. I worry about making that drastic of a change in p5 though hmmm. Will have to think about it more |
Copying customer ask here:
The text was updated successfully, but these errors were encountered: