Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Code Action Identifiers From Roslyn #5154

Closed
TanayParikh opened this issue Sep 16, 2020 · 8 comments · Fixed by #3335
Closed

Get Code Action Identifiers From Roslyn #5154

TanayParikh opened this issue Sep 16, 2020 · 8 comments · Fixed by #3335
Assignees

Comments

@TanayParikh
Copy link
Contributor

Currently we determine the type of code action via heuristics (ex. ends with Path for fully qualifying System.IO.Path). Optimally, we could get some kind of id/enum from roslyn which identifies the kind of the code action. This issue tracks adding support for this.

This would likely require expanding VSCodeAction to support a Kind. Alternatively we could add the Kind as part of VSCodeAction.Data.

This issue may require changes from LSP Platform / O#.

#2501 (comment)

@TanayParikh TanayParikh self-assigned this Sep 28, 2020
@TanayParikh
Copy link
Contributor Author

Pushing this to Preview3. PR is in progress, but haven't had time to complete it this cycle due to pull-diagnostics.

@TanayParikh
Copy link
Contributor Author

Blocked pending design review (Roslyn is considering making the ProviderName a part of the public API).

@TanayParikh
Copy link
Contributor Author

Design review notes;

  • Taking the Provider Names approach using PredefinedCode{Fix,Refactor}ProviderNames to allow Razor to filter out which Code Actions are made available to the user.
    • Doc comments in PredefinedCode{Fix,Refactor}ProviderNames.cs detailing the human process for refactors / new code action additions
    • Will consume Provider Name from string[] CodeAction.CustomTags

@TanayParikh
Copy link
Contributor Author

Tracking issue for Roslyn: dotnet/roslyn#4919

@TanayParikh
Copy link
Contributor Author

External, better idea of prioritization by EOW.

@TanayParikh
Copy link
Contributor Author

Should be landing shortly, unblocking the Razor use case.

@TanayParikh
Copy link
Contributor Author

The external work has been started.

Step 1; add the custom tags property for Code Actions: dotnet/roslyn#51456

@NTaylorMullen
Copy link
Contributor

@TanayParikh moved to in progress since you're kicking booty here 😉

@ghost ghost locked as resolved and limited conversation to collaborators May 2, 2021
@ghost ghost unlocked this conversation Oct 9, 2021
@allisonchou allisonchou transferred this issue from dotnet/aspnetcore Oct 9, 2021
@allisonchou allisonchou added this to the 16.10-Preview3 milestone Oct 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants