Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a named pipe to communicate projectinfo in vscode #10521

Merged
merged 34 commits into from
Jun 27, 2024
Merged

Use a named pipe to communicate projectinfo in vscode #10521

merged 34 commits into from
Jun 27, 2024

Commits on Jun 21, 2024

  1. Update ProjectInfo synchronization to use a named pipe instead of file 

    based approaches. The pipe will send updates that are serialized by
messagepack and then deserialize and enqueue project updates. This
should help improve project updates.

There's also numerous logging added to help diagnose where issues might
be coming from if users are hitting them.
    @ryzngard
    ryzngard committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    5b3f408 View commit details
    Browse the repository at this point in the history

  2. Clean up and move some logic into extension methods

    @ryzngard
    ryzngard committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    1dbd46d View commit details
    Browse the repository at this point in the history

  3. Use pooled arrays

    @ryzngard
    ryzngard committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    1718f43 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Remove file based project info settings

    @ryzngard
    ryzngard committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    cbe4b94 View commit details
    Browse the repository at this point in the history

  2. Woops

    @ryzngard
    ryzngard committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    b872a10 View commit details
    Browse the repository at this point in the history

  3. Make asynchronous

    @ryzngard
    ryzngard committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    16c6010 View commit details
    Browse the repository at this point in the history

  4. Fix tests and add serialization test

    @ryzngard
    ryzngard committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    c5a5faa View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Update src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Projec… 

    …tSystem/NamedPipeBasedRazorProjectInfoDriver.cs

Co-authored-by: Jared Parsons <[email protected]>
    @ryzngard @jaredpar
    ryzngard and jaredpar authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d641652 View commit details
    Browse the repository at this point in the history

  2. PR feedback. Allocate less. Bump some logs to information. Dispose st… 

    …ream
    @ryzngard
    ryzngard committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c48aac9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'named_pipe' of https://github.com/ryzngard/razor into n… 

    …amed_pipe
    @ryzngard
    ryzngard committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c32f25f View commit details
    Browse the repository at this point in the history

  4. Add ownership validation

    @ryzngard
    ryzngard committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    98c99c6 View commit details
    Browse the repository at this point in the history

  5. Stackalloc

    @ryzngard
    ryzngard committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7c006a8 View commit details
    Browse the repository at this point in the history

  6. Stackalloc for writing size

    @ryzngard
    ryzngard committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    4a445c2 View commit details
    Browse the repository at this point in the history

  7. usings...

    @ryzngard
    ryzngard committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2985b2e View commit details
    Browse the repository at this point in the history

  8. Dispose named pipe

    @ryzngard
    ryzngard committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7cde45f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Clean up and move to abstract to make testing easier

    @ryzngard
    ryzngard committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3aee1bf View commit details
    Browse the repository at this point in the history

  2. PR feedback and publicapi fixes

    @ryzngard
    ryzngard committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c8fe2dc View commit details
    Browse the repository at this point in the history

  3. Update src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Projec… 

    …tSystem/RazorConnectHandler.cs

Co-authored-by: Jared Parsons <[email protected]>
    @ryzngard @jaredpar
    ryzngard and jaredpar authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2a675c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Move to RZLS

    @ryzngard
    ryzngard committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6c4c79e View commit details
    Browse the repository at this point in the history

  2. Remove because cut/paste doesn't in VS

    @ryzngard
    ryzngard committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6717529 View commit details
    Browse the repository at this point in the history

  3. Be more clear about async work. Use local functions to help scope

    @ryzngard
    ryzngard committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    537b019 View commit details
    Browse the repository at this point in the history

  4. Copilot forgot my using!

    @ryzngard
    ryzngard committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e915417 View commit details
    Browse the repository at this point in the history

  5. Clean up loop expectation

    @ryzngard
    ryzngard committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    60f3661 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Fix tests

    @ryzngard
    ryzngard committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1979f0e View commit details
    Browse the repository at this point in the history

  2. Update PublicAPI.Unshipped.txt

    @ryzngard
    ryzngard committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    05ab5ff View commit details
    Browse the repository at this point in the history

  3. Productive discussion! Let's gooooo!

    @ryzngard
    ryzngard committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    3fa3205 View commit details
    Browse the repository at this point in the history

  4. LKJDLKSJFLKSJDFLKJDFLJSLFKDJSLDKFJ:LKj:LjKL:DJl;jak;ljfsdkl;ajfa;lksj… 

    …fd;lasjdfkl;jsakl;jdf;lkasj
    @ryzngard
    ryzngard committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    22c52d5 View commit details
    Browse the repository at this point in the history

  5. Be more clear about disposal state

    @ryzngard
    ryzngard committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    7103fb1 View commit details
    Browse the repository at this point in the history

  6. Use disposal token

    @ryzngard
    ryzngard committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    d548c02 View commit details
    Browse the repository at this point in the history

  7. PR feedback

    @ryzngard
    ryzngard committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    e6cc53a View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into named_pipe

    @ryzngard
    ryzngard committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    36dc320 View commit details
    Browse the repository at this point in the history

  9. Update src/Razor/src/Microsoft.AspNetCore.Razor.ExternalAccess.Roslyn… 

    …Workspace/RazorWorkspaceListenerBase.cs

Co-authored-by: David Wengier <[email protected]>
    @ryzngard @davidwengier
    ryzngard and davidwengier authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    81de399 View commit details
    Browse the repository at this point in the history

  10. Feedback

    @ryzngard
    ryzngard committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    88a359c View commit details
    Browse the repository at this point in the history

  11. Merge branch 'named_pipe' of https://github.com/ryzngard/razor into n… 

    …amed_pipe
    @ryzngard
    ryzngard committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1f9ae6d View commit details
    Browse the repository at this point in the history