Fix provisional completion corrupting generated C# documents #10806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… large chunk of the generated file
davidwengier
force-pushed
the
FixProvisionalCompletion
branch
from
8f6c6b4
to
39942a2
Compare
|
@phil-allen-msft I think we should take this for 17.12 Preview 2. It was broken in Preview 1, and it's pretty easy to hit. Essentially depending on where you type it, typing a |
phil-allen-msft
approved these changes
Aug 28, 2024
|
Verified this issue does not repro in VS 17.12 Preview 2 now |
|
My bad on this one 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10759
Initially when investigating this I was digging into buffer versions and race conditions, but now that the editor fix is in, and we are self versioned, the bug stood out much more obviously: A character offset was being passed in to a parameter that expected a length 🤦♂️
Sadly none of the
RazorCustomMessageTargetcode is testable. Cohosting will make this trivial though, as we would simply create a newDocumentwith the provisional change, and drop it on the floor when we're finished.