Fix some AssumeNotNull assumptions
#10901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
changed the title
AssumeNotNull assumptions
alexgav
reviewed
Sep 19, 2024
| @@ -30,6 +29,5 @@ public static TextChange GetTextChange(this SourceText text, TextEdit edit) | |||
| => new(text.GetTextSpan(edit.Range), edit.NewText); | |||
|
|
|||
| public static TextEdit GetTextEdit(this SourceText text, TextChange change) | |||
| => RoslynLspFactory.CreateTextEdit(text.GetRange(change.Span), change.NewText.AssumeNotNull()); | |||
|
|
|||
| => RoslynLspFactory.CreateTextEdit(text.GetRange(change.Span), change.NewText ?? ""); | |||
There was a problem hiding this comment.
IIRC, it does make a difference, but an absurdly small one. 😄
There was a problem hiding this comment.
I thought it didn't make a difference after .NET Framework 2.0 🤷♂️
There was a problem hiding this comment.
No, it definitely made a difference in .NET Framework 2.0. There was actually effort to inline string.Empty for empty string literals in the JIT more aggressively post .NET Framework 4.0. I know that because it caused a bug that @jasonmalinowski and I ran into where the value of string.Empty could become corrupted by the COM marshaller if strings were annotated incorrectly (e.g. BStr instead of LPWStr).
Crazy days.
DustinCampbell
approved these changes
Sep 19, 2024
|
Merging a PR from a plane... for the memes |
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most of the hits on https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2223687 in 17.12 P2 and above