Fix project publish (or: Various project system fixes) #10983
Merged
Commits on Oct 8, 2024
-
This was previously using the hash code of the document snapshot, therefore publishing every request. This meant we got publishes for old documents when they were superseded by newer ones.
-
Batch virtual document refreshes together
The things receiving project events on the server side were all batching their work together, so quick remove-then-add sequences for documents would be merged together on the server side. Not doing that on the client side too just made it much harder for things to ever be in sync.
-
Stop trying to guess which projects documents belong to
When publishing, we see a project remove for obj/Debug, and move all files to the misc project, then we'd see a new project for obj/Release, and add that. That add would then cause us to go through all of the misc files, and add them to the first project that could possibly have them - in this case, adding them right back to obj/Debug. Generally speaking we shouldn't be guessing at anything with project info, but rather rely on correct input from systems. ie, if they add a project, they presumably will then follow up with telling us which documents are in it.
-
Remove previous publish data when documents are removed
Now that snapshots are self-versioned, if we don't keep our "previously published data" clean we'll end up re-publishing versions of documents that are new on the client side, but not new on the server.
-
Don't publish documents that have been subsequently removed from the …
…project When all documents are removed from a project, if the imports file comes first, it will cause a recompile of all open razor files, even though they will themselves later on be removed. This didn't used to cause any issues during publish, because the generated document would be sent over, and later clobbered with a subsequent change. Now that documents are self-versioned, that subsequent change could be for a version number less than the removed document, and hence be thrown away. Plus it's wasted work.
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.