Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safely handle DirectoryNotFound #2008

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Safely handle DirectoryNotFound #2008

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
214dd4f
Safely handle DirectoryNotFound
TanayParikh Jun 10, 2020
a6cb8d9
Catch all
TanayParikh Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...or/src/Microsoft.AspNetCore.Razor.LanguageServer.Common/DefaultRemoteTextLoaderFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public override Task<TextAndVersion> LoadTextAndVersionAsync(Workspace workspace
throw new IOException($"File was externally modified: {_filePath}");
}
}
catch (FileNotFoundException)
catch (IOException e) when (e is DirectoryNotFoundException || e is FileNotFoundException)
{
// This can typically occur when a file is renamed. What happens is the client "closes" the old file before any file system "rename" event makes it to us. Resulting
// in us trying to refresh the "closed" files buffer with what's on disk; however, there's nothing actually on disk because the file was renamed.
Expand Down