Set noDebug flag on launch url for Blazor WASM apps #2393
Conversation
captainsafia
requested review from
ajaybhargavb,
NTaylorMullen,
ryanbrandenburg and
TanayParikh
as code owners
captainsafia
changed the title
once that's resolved.| const browser = { | ||
| name: JS_DEBUG_NAME, | ||
| type: configuration.browser === 'edge' ? 'pwa-msedge' : 'pwa-chrome', | ||
| request: 'launch', | ||
| timeout: configuration.timeout || 30000, | ||
| url: configuration.url || 'https://localhost:5001', | ||
| url: setNoDebugFlag(configuration.url || 'https://localhost:5001'), |
There was a problem hiding this comment.
If we don't enforce configuration.url not to have query-strings already this will break, right? If we enforce that already great, if not you might have to use a URL class/function to add the querystring in a more robust way.
There was a problem hiding this comment.
This change should be backwards compatible. If the query param is set but the framework doesn't contain the matching updates, then the flag will no-op.
If it is not set and the framework is updated then it defaults to true.
There was a problem hiding this comment.
Oh, I meant that if configuration.url = 'https://localhost:5001?somequeryString=stuff' then this new function does url:${configuration.url}?_blazor_debug=false`` then we end up with https://localhost:5001?somequeryString=stuff?_blazor_debug=false, which would result in some weird querystrings.
There was a problem hiding this comment.
Ah I see. We decided to keep the logic simple here. We don't anticipate that a lot of people will be launching with custom query strings. If they are, it's fairly easy to work around (e.g., edit the URL)/
We're adding a query parameter that will be set/unset if the Blazor WASM application is under debug.
This flag will determine whether or not the Mono runtime optimizes execution for debugging or performance.
The flag defaults to true for backwards-compatibility but we'll need to set it to false to disable debugging overhead and improve app performance. This change only affects apps built in Development mode.
This PR should be merged after dotnet/aspnetcore#24972.
Addresses dotnet/aspnetcore#24623