Remove BlazorWasmDebuggingExtension and get URL information from launchSettings.json #8253
Conversation
…ing URL information from launchSettings.json
…ttp://localhost:7104;https://localhost:7105"
|
This is an interesting one, @thaystg! I'd love for customers to be able to debug Blazor WASM projects without the need of this extension. But will this change allow to debug projects in all the scenarios where it was possible with the extension? |
Probably I'm not the most expert person to answer this question, maybe @captainsafia is the right person. We needed to remove the other way to startup the BrowserDebugProxy because it was not possible to detect which was the correct version to start: .net6 or .net7 for example. |
| const launchSettings = JSON.parse(readFileSync(join(folderPath, 'Properties', 'launchSettings.json'), 'utf8')); | ||
| if (launchSettings?.profiles && launchSettings?.profiles[Object.keys(launchSettings.profiles)[0]]?.inspectUri) { | ||
| inspectUri = launchSettings.profiles[Object.keys(launchSettings.profiles)[0]].inspectUri; | ||
| url = launchSettings.profiles[Object.keys(launchSettings.profiles)[0]].applicationUrl.split(';', 1)[0]; |
There was a problem hiding this comment.
Nice to see that we will be trying to get the URL from the launchSettings going forward 👍
|
@phil-allen-msft, @davidwengier can you guys merge this given that it's ready to be merged? |
| result ? result.inspectUri : undefined, | ||
| result ? result.debuggingPort : undefined); | ||
| inspectUri, | ||
| url); |
There was a problem hiding this comment.
Before, this was the result.debuggingPort, which seems like it would be a number. Now it's a URL; is this expected?
There was a problem hiding this comment.
result.debuggingPort is not used anymore, this is expected.
|
@mkArtakMSFT this PR is already shipped? |
Trying to completely remove the BlazorWasmDebuggingExtension and getting URL information from launchSettings.json
Fixes: dotnet/vscode-csharp#5501
Related: dotnet/vscode-csharp#5579