Create some simple tests for the RoslynWorkspace EA #8607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Apr 18, 2023
| @@ -11,15 +10,12 @@ public class RazorWorkspaceListener : IDisposable | |||
| private static readonly TimeSpan s_debounceTime = TimeSpan.FromMilliseconds(100); | |||
|
|
|||
| private string? _projectRazorJsonFileName; | |||
| private readonly Dictionary<string, TaskDelayScheduler> _workQueues; | |||
| private readonly Dictionary<ProjectId, TaskDelayScheduler> _workQueues; | |||
There was a problem hiding this comment.
Changed the key here to make testing easier, but also strictly speaking the previous code wouldn't have worked for multi targetting, should that ever be something someone wants to do.
davidwengier
commented
Apr 18, 2023
| { | ||
| scheduler = new TaskDelayScheduler(s_debounceTime, CancellationToken.None); | ||
| _workQueues.Add(project.Id, scheduler); |
There was a problem hiding this comment.
Stupid bug here. I wasn't actually adding anything to the map 🤦♂️
davidwengier
commented
Apr 18, 2023
| case WorkspaceChangeKind.SolutionChanged: | ||
| case WorkspaceChangeKind.SolutionReloaded: | ||
| foreach (var project in e.OldSolution.Projects) |
There was a problem hiding this comment.
Figured now that we're using IDs, its better to be a bit more strict with removal so we're not holding stale data in the map. Not a big deal though, as removing and re-adding the same project is essentially the same as queuing an update anyway, and any stale projects here will just be an instance of the TaskDelayScheduler that does nothing.
allisonchou
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.