Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tooltip fix for hover and code completion on VS code #9862

Merged
merged 5 commits into from
Jan 29, 2024
Merged

tooltip fix for hover and code completion on VS code #9862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a50c487
Update DefaultLSPTagHelperTooltipFactory.cs
jordi1215 Jan 25, 2024
7a99d7b
Changed united tests for hover
jordi1215 Jan 26, 2024
64b28a0
make only the final tagHelperType name bold
jordi1215 Jan 29, 2024
86b3c80
Using the range operator
jordi1215 Jan 29, 2024
1dd0356
Update HoverInfoServiceTest.cs
jordi1215 Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...rc/Microsoft.AspNetCore.Razor.LanguageServer/Tooltip/DefaultLSPTagHelperTooltipFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,14 @@ public override bool TryCreateTooltip(

var tagHelperType = descriptionInfo.TagHelperTypeName;
var reducedTypeName = ReduceTypeName(tagHelperType);

// If the reducedTypeName != tagHelperType, then the type is prefixed by a namespace
if (reducedTypeName != tagHelperType)
{
descriptionBuilder.Append(tagHelperType[..^reducedTypeName.Length]);
}

// We make the reducedTypeName bold while leaving the namespace intact
StartOrEndBold(descriptionBuilder, markupKind);
descriptionBuilder.Append(reducedTypeName);
StartOrEndBold(descriptionBuilder, markupKind);
Expand Down
8 changes: 4 additions & 4 deletions ....AspNetCore.Razor.LanguageServer.Test/Completion/DefaultLSPTagHelperTooltipFactoryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public void TryCreateTooltip_Markup_Element_SingleAssociatedTagHelper_ReturnsTru

// Assert
Assert.True(result);
Assert.Equal(@"**SomeTagHelper**
Assert.Equal(@"Microsoft.AspNetCore.**SomeTagHelper**

Uses `List<System.String>`s", markdown.Value);
Assert.Equal(MarkupKind.Markdown, markdown.Kind);
Expand All @@ -115,7 +115,7 @@ public void TryCreateTooltip_Markup_Element_PlainText_NoBold()

// Assert
Assert.True(result, "TryCreateTooltip should have succeeded");
Assert.Equal(@"SomeTagHelper
Assert.Equal(@"Microsoft.AspNetCore.SomeTagHelper

Uses `List<System.String>`s", markdown.Value);
Assert.Equal(MarkupKind.PlainText, markdown.Kind);
Expand Down Expand Up @@ -166,11 +166,11 @@ public void TryCreateTooltip_Markup_Element_MultipleAssociatedTagHelpers_Returns

// Assert
Assert.True(result);
Assert.Equal(@"**SomeTagHelper**
Assert.Equal(@"Microsoft.AspNetCore.**SomeTagHelper**

Uses `List<System.String>`s
---
**OtherTagHelper**
Microsoft.AspNetCore.**OtherTagHelper**

Also uses `List<System.String>`s", markdown.Value);
Assert.Equal(MarkupKind.Markdown, markdown.Kind);
Expand Down